Skip to content

Commit

Permalink
Merge branch 'master' into make-deprecation-workflow-built-in
Browse files Browse the repository at this point in the history
  • Loading branch information
wycats authored Sep 19, 2024
2 parents 9310137 + 3e03230 commit 639b3dd
Show file tree
Hide file tree
Showing 17 changed files with 2,944 additions and 23 deletions.
6 changes: 3 additions & 3 deletions text/0496-handlebars-strict-mode.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,14 @@
---
stage: released
stage: recommended
start-date: 2019-02-14T00:00:00.000Z
release-date: 2021-05-03T00:00:00.000Z
release-versions:
ember-source: v3.27.0

teams:
- framework
prs:
accepted: https://github.com/emberjs/rfcs/pull/496
accepted: 'https://github.com/emberjs/rfcs/pull/496'
recommended: 'https://github.com/emberjs/rfcs/pull/1024'
project-link:
---

Expand Down
8 changes: 7 additions & 1 deletion text/0726-dom-element-descriptor-interface.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,12 @@
---
stage: ready-for-release
stage: recommended
start-date: 2021-03-13T00:42:02.085Z
release-date:
release-versions:
dom-element-descriptors: 0.5.1
'@ember/test-helpers': 3.3.0
qunit-dom: 3.2.0
fractal-page-object: 1.0.0
teams:
- cli
- framework
Expand All @@ -11,6 +15,8 @@ teams:
prs:
accepted: 'https://github.com/emberjs/rfcs/pull/726'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/992'
released: 'https://github.com/emberjs/rfcs/pull/1004'
recommended: 'https://github.com/emberjs/rfcs/pull/1039'
project-link:
suite:
---
Expand Down
11 changes: 7 additions & 4 deletions text/0774-implicit-record-route-loading.md
Original file line number Diff line number Diff line change
@@ -1,14 +1,17 @@
---
stage: released
stage: recommended
start-date: 2021-11-14T00:00:00.000Z
release-date:
release-date: 2024-03-04T00:00:00.00Z
release-versions:
ember-source: v5.7.0
ember-cli: v5.7.0
teams:
- framework
prs:
accepted: 'https://github.com/emberjs/rfcs/pull/774'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/900'
released: 'https://github.com/emberjs/rfcs/pull/955'
recommended: 'https://github.com/emberjs/rfcs/pull/970'
---

# Deprecate Implicit Record Loading in Routes
Expand Down Expand Up @@ -46,9 +49,9 @@ By removing this behaviour, we will encourage developers to explicitly define wh

We will issue a deprecation to [`findModel`](https://github.com/emberjs/ember.js/blob/017b11e2f58880869a5b8c647bf7f3199fc07f26/packages/%40ember/-internals/routing/lib/system/route.ts#L1376) notifying the user that if they want to continue this behaviour of attempting to fetch a resource implicitly, they should try and replicate with their own explicitly defined `model` hook.

In addition, we will include an [optional feature](https://github.com/emberjs/ember-optional-features) to disable this feature and clear the deprecation.
In addition, we will include an [optional feature](https://github.com/emberjs/ember-optional-features) to disable this feature and clear the deprecation. This optional feature will be enabled in the blueprint because we want new apps to get this behaviour by default.

In v6.0.0, we will remove `findModel` and logic to determine arguments for this method. This will not remove returning the `transition` context when no `model` hook is defined.
In v6.0.0, we will remove `findModel` and logic to determine arguments for this method. This will not remove returning the `transition` context when no `model` hook is defined. The optional feature will also be removed.

## How we teach this

Expand Down
16 changes: 9 additions & 7 deletions text/0831-standardize-use-npm-yarn.md
Original file line number Diff line number Diff line change
@@ -1,15 +1,18 @@
---
stage: accepted
stage: recommended
start-date: 2022-07-22T00:00:00.000Z
release-date: Unreleased
release-date: 2024-04-19T00:00:00.000Z
release-versions:
teams: # delete teams that aren't relevant
teams:
- cli
- learning
prs:
accepted: https://github.com/emberjs/rfcs/pull/831
project-link: https://github.com/ember-learn/cli-guides/issues/272
suite:
accepted: 'https://github.com/emberjs/rfcs/pull/831'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/959'
released: 'https://github.com/emberjs/rfcs/pull/1018'
recommended: 'https://github.com/emberjs/rfcs/pull/1019'
project-link: 'https://github.com/ember-learn/cli-guides/issues/272'
suite:
---

<!---
Expand All @@ -25,7 +28,6 @@ RFC PR: Fill this in with the URL for the Proposal RFC PR

# Standardize use of scripts in package.json for common tasks

Standardize the use of yarn and npm scripts in the Ember experience

## Summary

Expand Down
7 changes: 5 additions & 2 deletions text/0848-deprecate-array-prototype-extensions.md
Original file line number Diff line number Diff line change
@@ -1,12 +1,15 @@
---
stage: accepted
stage: released
start-date: 2022-08-21T00:00:00.000Z
release-date:
release-versions:
ember-source: 5.10.0
teams:
- framework
prs:
accepted: https://github.com/emberjs/rfcs/pull/848
accepted: 'https://github.com/emberjs/rfcs/pull/848'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/1020'
released: 'https://github.com/emberjs/rfcs/pull/1042'
project-link:
---

Expand Down
15 changes: 9 additions & 6 deletions text/0984-update-browser-support-policy.md
Original file line number Diff line number Diff line change
@@ -1,19 +1,22 @@
---
stage: accepted
start-date: 2023-11-02T15:40:00.000Z
release-date: # In format YYYY-MM-DDT00:00:00.000Z
stage: recommended
start-date: 2023-11-02T15:40:00.000Z
release-date: 2024-05-10T00:00:00.000Z
release-versions:
teams: # delete teams that aren't relevant
teams:
- cli
- data
- framework
- learning
- steering
- typescript
prs:
accepted: https://github.com/emberjs/rfcs/pull/984
accepted: 'https://github.com/emberjs/rfcs/pull/984'
ready-for-release: 'https://github.com/emberjs/rfcs/pull/1005'
released: 'https://github.com/emberjs/rfcs/pull/1021'
recommended: 'https://github.com/emberjs/rfcs/pull/1025'
project-link:
suite:
suite:
---


Expand Down
Loading

0 comments on commit 639b3dd

Please sign in to comment.