This repository has been archived by the owner on May 26, 2019. It is now read-only.
Add wait helper documentation to component testing guide #911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
toddjordan
force-pushed
the
add-wait-helper-to-testing-components
branch
from
a8da4cf
to
c6833b7
Compare
| `wait` helper is designed to handle these these scenarios, by providing a hook to ensure assertions are made after | ||
| all ajax requests and timers are complete. | ||
|
|
||
| Imagine you have a typahead component that uses `Ember.run.debounce` to limit requests to the server, and you want |
There was a problem hiding this comment.
Add a link to http://emberjs.com/api/classes/Ember.run.html#method_debounce, and briefly explain what it does.
|
This looks great! I added a couple comments. @locks can you look over it as well? |
toddjordan
force-pushed
the
add-wait-helper-to-testing-components
branch
from
c6833b7
to
37e0d30
Compare
update some wording around the test address review comments spelling fix
toddjordan
force-pushed
the
add-wait-helper-to-testing-components
branch
from
37e0d30
to
fa9d353
Compare
locks
added a commit
that referenced
this pull request
Oct 23, 2015
…mponents Add wait helper documentation to component testing guide
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix to issue #909
I created an example I thought might be fairly common. I would use an ajax example but I didn't want to complicate things by using something like pretender in the guides. Am open to suggestions though.