itemController property can also take a controller class directly.

[blessanm86]

Updated the documentation for itemController.

This aims to implement the issue discussed at #5174

[rwjblue]

Lookin' pretty good, will need some tests before we can merge it.

[blessanm86]

@rwjblue Thanks for reviewing this. Will look into adding some tests. Can this pull request be considered as a bug fix or does it need to be a feature under a flag?

[rwjblue]

Hmm, I think it is a feature, so it should be flagged.

[stefanpenner]

+1 but ya should be feature flagged.

[blessanm86]

Feature flagged the code and test. Prefixed the commit and added an entry in the features json and md file. Is there anything else? @rwjblue @stefanpenner

[rwjblue]

This should be {String|Ember.Controller} or something (to indicate that it accepts either).

[blessanm86]

@rwjblue I've updated the documentation.

[tomdale]

At today's core team meeting, we decided to no-go this feature because we are deprecating item controllers and recommend users start migrating from item controllers to components.

[workmanw]

@tomdale et al

I'd love to hear what the recommended pattern for this is. In our app, we have a few itemControllers that are really "helpers" for things like action handling and CP data transformation. They end up with a lot of reuse through out the app, but have different markup. Something like this:

{{#each user in loggedInUsers itemController="user"}}
  <label>Name:</label>  {{user.displayName}}
  <label>Last Login:</label> {{user.lastLogin}}
{{/each}}

At first, I thought it might be something like this:

{{#each user in loggedInUsers}}
  {{#user-widget user=user}}
    <label>Name:</label>{{controller.displayName}}
    <label>Last Login:</label> {{user.lastLogin}}
  {{/user-widget}}
{{/each}}

But that leaves me with a conundrum, how do I access the component scope within the template? {{controller}} doesn't work, neither does {{view}}. Is there a way to do this? The same goes for action targets as well. Adding an {{action}} to the the user's displayName will always target the controller for the template's primary scope, not for the parent component.

[tomdale]

@workmanw Block params should solve this problem for you:

{{#each user in loggedInUsers}}
  {{#user-widget user=user as |component|}}}
    <label>Name:</label>{{component.displayName}}
    <label>Last Login:</label> {{user.lastLogin}}
  {{/user-widget}}
{{/each}}

(The component can yield whatever it wants into the block params, including itself.)