[Bugfix Beta] Fix issue with renderer's cleanup since the introduction of renderComponent #20974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullVoxPopuli
commented
Sep 8, 2025
| `, | ||
| }, | ||
| integration: { | ||
| 'destruction-test.gjs': ` |
Contributor
Author
There was a problem hiding this comment.
this test is passing in 6.7
Estimated Asset SizesDiff --- main/out.txt 2025-09-08 20:38:42.000000000 +0000
+++ pr/./pr-17568479549/out.txt 2025-09-09 01:01:24.000000000 +0000
@@ -1,34 +1,34 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 418.65 KB │ 232.22 KB ║
+║ Total │ 418.65 KB │ 232.25 KB ║
╚═══════╧═══════════╧═══════════╝
╔══════════════════════╤══════════╤═══════════╗
║ @ember/* │ Min │ Gzip ║
╟──────────────────────┼──────────┼───────────╢
-║ Total │ 239.4 KB │ 147.23 KB ║
+║ Total │ 239.4 KB │ 147.26 KB ║
╟──────────────────────┼──────────┼───────────╢
-║ -internals │ 35.46 KB │ 25.49 KB ║
-║ application │ 12.83 KB │ 7.7 KB ║
+║ -internals │ 35.46 KB │ 25.5 KB ║
+║ application │ 12.83 KB │ 7.66 KB ║
║ array │ 12.66 KB │ 7.32 KB ║
║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 1005 B ║
+║ component │ 1.07 KB │ 1.01 KB ║
║ controller │ 1.8 KB │ 1.36 KB ║
║ debug │ 11.4 KB │ 7.92 KB ║
║ deprecated-features │ 31 B │ 77 B ║
║ destroyable │ 561 B │ 383 B ║
║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 605 B ║
+║ helper │ 823 B │ 596 B ║
║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 581 B ║
+║ modifier │ 669 B │ 588 B ║
║ object │ 33.78 KB │ 20.79 KB ║
║ owner │ 159 B │ 178 B ║
-║ renderer │ 406 B │ 350 B ║
-║ routing │ 58.08 KB │ 33.43 KB ║
+║ renderer │ 406 B │ 366 B ║
+║ routing │ 58.08 KB │ 33.45 KB ║
║ runloop │ 2.2 KB │ 1.33 KB ║
║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 364 B ║
+║ template │ 430 B │ 352 B ║
║ template-compilation │ 429 B │ 366 B ║
║ template-compiler │ 57.91 KB │ 30.4 KB ║
║ template-factory │ 94 B │ 160 B ║Details
|
NullVoxPopuli
commented
Sep 8, 2025
Contributor
Author
There was a problem hiding this comment.
I couldn't find any place @glimmer/component was tested, so I just added some tests here
NullVoxPopuli
changed the title
NullVoxPopuli
changed the title
ef4
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From: https://github.com/bertdeblock/failing-ember-beta-test
Very surprised our existing tests didn't catch this
It turns out we haven't been doing much owner-linked destruction testing.
If folks use clearRender, things work great.
The issue is that if the owner is destroyed, we want everything used with the owner to also be destroyed -- and somehow this linkage got missed during the renderComponent work.
Implementation PR, for reference: #20962