Upgrade glimmer-vm (get the built in built-ins) #20950
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Estimated Asset SizesDiff --- main/out.txt 2025-08-03 00:53:46.000000000 +0000
+++ pr/./pr-16763052327/out.txt 2025-08-05 22:50:26.000000000 +0000
@@ -1,46 +1,46 @@
╔═══════╤═══════════╤═══════════╗
║ │ Min │ Gzip ║
╟───────┼───────────┼───────────╢
-║ Total │ 408.84 KB │ 228.88 KB ║
+║ Total │ 418.48 KB │ 231.88 KB ║
╚═══════╧═══════════╧═══════════╝
-╔══════════════════════╤═══════════╤══════════╗
-║ @ember/* │ Min │ Gzip ║
-╟──────────────────────┼───────────┼──────────╢
-║ Total │ 239.23 KB │ 147.2 KB ║
-╟──────────────────────┼───────────┼──────────╢
-║ -internals │ 35.44 KB │ 25.49 KB ║
-║ application │ 12.83 KB │ 7.62 KB ║
-║ array │ 12.66 KB │ 7.32 KB ║
-║ canary-features │ 304 B │ 419 B ║
-║ component │ 1.07 KB │ 1004 B ║
-║ controller │ 1.8 KB │ 1.36 KB ║
-║ debug │ 11.4 KB │ 7.92 KB ║
-║ deprecated-features │ 31 B │ 77 B ║
-║ destroyable │ 561 B │ 383 B ║
-║ enumerable │ 259 B │ 387 B ║
-║ helper │ 823 B │ 570 B ║
-║ instrumentation │ 2.43 KB │ 1.78 KB ║
-║ modifier │ 669 B │ 614 B ║
-║ object │ 33.78 KB │ 20.79 KB ║
-║ owner │ 159 B │ 178 B ║
-║ renderer │ 385 B │ 327 B ║
-║ routing │ 58.05 KB │ 33.43 KB ║
-║ runloop │ 2.2 KB │ 1.33 KB ║
-║ service │ 859 B │ 741 B ║
-║ template │ 430 B │ 390 B ║
-║ template-compilation │ 429 B │ 366 B ║
-║ template-compiler │ 57.81 KB │ 30.44 KB ║
-║ template-factory │ 94 B │ 160 B ║
-║ test │ 923 B │ 627 B ║
-║ utils │ 3.93 KB │ 3.5 KB ║
-║ version │ 55 B │ 131 B ║
-╚══════════════════════╧═══════════╧══════════╝
+╔══════════════════════╤═══════════╤═══════════╗
+║ @ember/* │ Min │ Gzip ║
+╟──────────────────────┼───────────┼───────────╢
+║ Total │ 239.23 KB │ 147.06 KB ║
+╟──────────────────────┼───────────┼───────────╢
+║ -internals │ 35.44 KB │ 25.49 KB ║
+║ application │ 12.83 KB │ 7.62 KB ║
+║ array │ 12.66 KB │ 7.32 KB ║
+║ canary-features │ 304 B │ 419 B ║
+║ component │ 1.07 KB │ 1004 B ║
+║ controller │ 1.8 KB │ 1.36 KB ║
+║ debug │ 11.4 KB │ 7.92 KB ║
+║ deprecated-features │ 31 B │ 77 B ║
+║ destroyable │ 561 B │ 383 B ║
+║ enumerable │ 259 B │ 387 B ║
+║ helper │ 823 B │ 570 B ║
+║ instrumentation │ 2.43 KB │ 1.78 KB ║
+║ modifier │ 669 B │ 614 B ║
+║ object │ 33.78 KB │ 20.79 KB ║
+║ owner │ 159 B │ 178 B ║
+║ renderer │ 385 B │ 327 B ║
+║ routing │ 58.05 KB │ 33.43 KB ║
+║ runloop │ 2.2 KB │ 1.33 KB ║
+║ service │ 859 B │ 741 B ║
+║ template │ 430 B │ 390 B ║
+║ template-compilation │ 429 B │ 366 B ║
+║ template-compiler │ 57.81 KB │ 30.3 KB ║
+║ template-factory │ 94 B │ 160 B ║
+║ test │ 923 B │ 627 B ║
+║ utils │ 3.93 KB │ 3.5 KB ║
+║ version │ 55 B │ 131 B ║
+╚══════════════════════╧═══════════╧═══════════╝
╔═════════════════╤═══════════╤══════════╗
║ @glimmer/* │ Min │ Gzip ║
╟─────────────────┼───────────┼──────────╢
-║ Total │ 169.61 KB │ 81.68 KB ║
+║ Total │ 179.25 KB │ 84.81 KB ║
╟─────────────────┼───────────┼──────────╢
║ destroyable │ 2.7 KB │ 1.35 KB ║
║ encoder │ 596 B │ 653 B ║
@@ -55,7 +55,7 @@
║ runtime │ 95.26 KB │ 42.51 KB ║
║ tracking │ 989 B │ 961 B ║
║ util │ 3.03 KB │ 2.29 KB ║
-║ validator │ 6 KB │ 3.72 KB ║
+║ validator │ 15.64 KB │ 6.86 KB ║
║ vm │ 784 B │ 798 B ║
║ wire-format │ 1.84 KB │ 1.35 KB ║
╚═════════════════╧═══════════╧══════════╝Details
|
btecu
reviewed
Jul 27, 2025
btecu
reviewed
Jul 27, 2025
NullVoxPopuli
force-pushed
the
nvp/upgrade-vm-main
branch
from
986a8b8 to
6eeb818
Compare
NullVoxPopuli
changed the title
NullVoxPopuli
commented
Aug 5, 2025
| @@ -0,0 +1,8 @@ | |||
| export { | |||
| trackedArray, | |||
Contributor
Author
There was a problem hiding this comment.
JSDoc does come through here from @glimmer/validator
kategengler
approved these changes
Aug 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have to drop TS < 5.2 -- we were testing against TS 5.0 and TS 5.1.
This is because TS 5.1 does not have the
WeakKeytype.Update to our TypeScript support table here: ember-learn/ember-website#1166
What we get with this upgrade
In this PR:
@ember/reactive(/.+)?When using tarballs:
How to update this PR when glimmer-vm updates:
mainpnpm link:allNullVoxPopuli:nvp/upgrade-vm-maincp ../path/to/glimmer-vm/dist/*.tgz ./node ./bin/use-vm-tarballs.mjspnpm installpnpm startUsing my branch in
emberjs: