-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
[Next] Kill Action Mixins #20919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Next] Kill Action Mixins #20919
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Development AssetsDiff --- main/out.txt 2025-06-11 01:12:44.000000000 +0000
+++ pr/./pr-15589365336/out.txt 2025-06-11 15:40:58.000000000 +0000
@@ -1,33 +1,32 @@
2.2M └─┬ .
-996K ├─┬ @ember
-187K │ ├─┬ -internals
- 50K │ │ ├─┬ views
- 46K │ │ │ └─┬ lib
+948K ├─┬ @ember
+180K │ ├─┬ routing
+ 27K │ │ └── lib
+165K │ ├─┬ -internals
+ 44K │ │ ├─┬ views
+ 39K │ │ │ └─┬ lib
21K │ │ │ ├── system
- 10K │ │ │ ├── views
-5.6K │ │ │ ├── mixins
+9.1K │ │ │ ├── views
4.3K │ │ │ └── compat
- 35K │ │ ├─┬ runtime
- 30K │ │ │ └─┬ lib
- 21K │ │ │ ├── mixins
-5.7K │ │ │ └── ext
26K │ │ ├─┬ meta
21K │ │ │ └── lib
+ 20K │ │ ├─┬ runtime
+ 16K │ │ │ └─┬ lib
+6.4K │ │ │ ├── mixins
+5.7K │ │ │ └── ext
11K │ │ ├── owner
9.4K │ │ ├── deprecations
-7.4K │ │ ├── metal
+7.3K │ │ ├── metal
7.0K │ │ ├── string
5.0K │ │ ├── glimmer
-4.9K │ │ ├── utils
4.9K │ │ ├── routing
+4.8K │ │ ├── utils
4.5K │ │ ├── error-handling
4.5K │ │ ├── utility-types
4.2K │ │ ├── container
4.2K │ │ ├── browser-environment
4.1K │ │ └── environment
-183K │ ├─┬ routing
- 28K │ │ └── lib
-149K │ ├─┬ object
+140K │ ├─┬ object
66K │ │ └─┬ lib
62K │ │ └── computed
114K │ ├─┬ template-compiler
@@ -37,19 +36,19 @@
4.1K │ │ └── -internal
65K │ ├─┬ application
5.6K │ │ └── lib
- 52K │ ├─┬ debug
+ 51K │ ├─┬ debug
21K │ │ └── lib
- 38K │ ├─┬ array
-4.9K │ │ └── lib
- 31K │ ├─┬ engine
+ 30K │ ├─┬ engine
4.7K │ │ └── lib
- 27K │ ├── runloop
+ 27K │ ├─┬ array
+4.8K │ │ └── lib
+ 26K │ ├── runloop
22K │ ├─┬ utils
- 18K │ │ └── lib
+ 17K │ │ └── lib
20K │ ├── helper
11K │ ├── destroyable
9.8K │ ├── instrumentation
-9.4K │ ├── controller
+9.0K │ ├── controller
7.4K │ ├── service
7.2K │ ├── owner
6.2K │ ├── component
@@ -63,7 +62,7 @@
4.2K │ ├── deprecated-features
4.1K │ ├── template-factory
4.1K │ └── version
-722K ├── shared-chunks
+719K ├── shared-chunks
384K ├─┬ @glimmer
166K │ ├── runtime
60K │ ├── opcode-compiler
@@ -82,15 +81,15 @@
4.9K │ ├── encoder
4.6K │ ├── owner
4.1K │ └── env
- 60K ├─┬ ember-testing
- 55K │ └─┬ lib
+ 58K ├─┬ ember-testing
+ 54K │ └─┬ lib
14K │ ├── test
- 14K │ ├── helpers
+ 13K │ ├── helpers
10K │ ├── ext
6.4K │ └── adapters
31K ├── backburner.js
- 25K ├── ember
24K ├── route-recognizer
+ 24K ├── ember
18K ├─┬ @simple-dom
14K │ └── document
9.2K ├── dag-map Details
|
0db53c3
to
af6cb07
Compare
wagenet
commented
Jun 11, 2025
af6cb07
to
a6760ec
Compare
This was referenced Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To merge this to main we would have to deprecate
send
and the actions hash.