Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump all glimmer-vm dependencies to 0.87.1 #20609

Merged
merged 6 commits into from
Jan 2, 2024
Merged

Bump all glimmer-vm dependencies to 0.87.1 #20609

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8506838
Bump all glimmer-vm dependencies to 0.86
NullVoxPopuli Dec 20, 2023
947c082
'Fix' type issue
NullVoxPopuli Dec 20, 2023
14d0162
Upgrade glimmer-vm again
NullVoxPopuli Dec 24, 2023
3773999
Upgrade to 0.87.1
NullVoxPopuli Dec 24, 2023
8dc824e
Remove test from the IE11 days
NullVoxPopuli Dec 26, 2023
1ea6c40
Merge branch 'main' into upgrade-to-glimmer-vm-0-86
ef4 Jan 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/@ember/-internals/glimmer/lib/utils/bindings.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,9 @@ export function installAttributeBinding(
let [prop, attribute, isSimple] = parsed;

if (attribute === 'id') {
let elementId = get(component, prop);
// SAFETY: `get` could not infer the type of `prop` and just gave us `unknown`.
// we may want to throw an error in the future if the value isn't string or null/undefined.
let elementId = get(component, prop) as string | null;
Comment on lines +61 to +63
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

N.b. the right way to do this is to use a dev-time assert() that is stripped in prod builds instead!

if (elementId === undefined || elementId === null) {
elementId = component.elementId;
}
Expand Down
Loading