Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX stable] Fix model arg to a Route serialize #20490

Merged
merged 1 commit into from
Jun 29, 2023

Commits on Jun 29, 2023

  1. [BUGFIX stable] Fix model arg to a Route serialize

    Previously, the internal type here always explicitly added `| undefined`
    to the type of the `model` param. This was likely reasonable when the
    conversion first happened, since the type here was simply a minimal
    `IModel | undefined`. Since the param is now driven by the type param
    for the `Route`, though, and defaults to `unknown`, we can just use the
    `Model` type param directly, and the implementation handles it correctly
    since the was actually already, albeit invisibly, just `unknown`, since
    `unknown | undefined` === `unknown`.
    chriskrycho committed Jun 29, 2023
    Configuration menu
    Copy the full SHA
    3b83530 View commit details
    Browse the repository at this point in the history