[CLEANUP] Finish cleaning up Location interface
#20416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
force-pushed
the
more-autolocation-cleanup
branch
2 times, most recently
from
5bf26aa
to
e748ca7
Compare
- Remove `detect` and `implementation` from interface and its implementations. - Just use normal JS property setters instead of `set`. - Improve type safety in several spots.
chriskrycho
force-pushed
the
more-autolocation-cleanup
branch
from
e748ca7
to
5399689
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Catches the last few pieces ID'd by @sandstrom in #20406 as well as miscellaneous clean-up of the classes I noticed while working on them. 🎉
detectandimplementationfrom interface and its implementations.set.