Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX LTS] Fix runloop types on TS 5.0+ #20398

Merged
merged 1 commit into from
Mar 4, 2023

Conversation

Andarist
Copy link
Contributor

@Andarist Andarist commented Mar 4, 2023

related to microsoft/TypeScript#53080


Edit by @chriskrycho, 2023/03/04: TS 5.0 catches a new assignability error here, and our (very) complicated set of types for bind and friends got flagged by that. The terminal case for PartialParams needs to be a fixed empty tuple rather than never, so that the type system can see that it will be resolved as 'no arguments' rather than 'nothing' in that scenario.

Note: this fixes the one bug on our side. There is also a bug fix in the latest TS nightly (typescript@next) build, which combined with this PR should get us unblocked against TS nightlies again. We're in good shape for TS 5.0 and the upcoming 5.1 as a result!

Note: I have marked this as BUGFIX LTS because it affects our build. End users will not be affected by these changes until we have types publishing from source for this (presumably in 5.1 or 5.2), but any fixes we do make to 4.8 or 4.12 will see this in their CI runs, so we need to back-port it.

Copy link
Contributor

@chriskrycho chriskrycho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, totally didn't see this before opening #20400, which I can now close as a duplicate – thank you!

@chriskrycho chriskrycho changed the title Fixed a fallback branch in PartialParams type [BUGFIX LTS] Fix runloop types on TS 5.0+ Mar 4, 2023
@chriskrycho chriskrycho added Bug TypeScript Work on Ember’s types labels Mar 4, 2023
@chriskrycho chriskrycho merged commit f148ec4 into emberjs:master Mar 4, 2023
@Andarist Andarist deleted the patch-1 branch March 4, 2023 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug TypeScript Work on Ember’s types
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants