-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Stable types for @ember/polyfill
#20325
[FEATURE] Stable types for @ember/polyfill
#20325
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent! This also needs the corresponding entries (and files!) removed from the preview types. Once you do that, ping me and I'll re-review and land it. Thank you!
Ah, that step is missing from #19946 (comment) In this case, the preview types are OR Should I update the types (and tests) to match those in the
|
I think updating to match the types for |
@theroncross are you still up to finish updating this? Would love to land it! |
The updated types and tests now match those of `Object.assign` toward emberjs#19946
b82b4c4
to
dd50deb
Compare
Sorry about that. Got sidetracked by life a bit. The tests needed some changes to match the |
Sweet, will take a look tomorrow, and just re-approved CI! Thank you! |
@@ -7,7 +7,7 @@ import { deprecate } from '@ember/debug'; | |||
export function assign<T, U>(target: T, source: U): T & U; | |||
export function assign<T, U, V>(target: T, source1: U, source2: V): T & U & V; | |||
export function assign<T, U, V, W>(target: T, source1: U, source2: V, source3: W): T & U & V & W; | |||
export function assign(target: object, ...sources: object[]): object; | |||
export function assign(target: object, ...sources: any[]): any; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:sigh: This is probably the “right” thing to do here, since it’s what TS itself has, but I hate it.
@ember/polyfill
@theroncross looks good overall but I think some of the type tests will need updating! |
@theroncross I think we're going to end up closing this as "not needed" since it's all removed as of Ember v5. Thank you again, though! |
Superseded here specifically by #20380. |
toward #19946