Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing Firefox detection using InstallTrigger resolves #20098 #20126

Merged
merged 1 commit into from
Jun 21, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions packages/@ember/-internals/browser-environment/index.ts
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import hasDom from './lib/has-dom';

declare const InstallTrigger: unknown;
declare const chrome: unknown;
declare const opera: unknown;
declare const MSInputMethodContext: unknown;
Expand All @@ -12,7 +11,7 @@ export const location = hasDom ? self.location : null;
export const history = hasDom ? self.history : null;
export const userAgent = hasDom ? self.navigator.userAgent : 'Lynx (textmode)';
export const isChrome = hasDom ? typeof chrome === 'object' && !(typeof opera === 'object') : false;
export const isFirefox = hasDom ? typeof InstallTrigger !== 'undefined' : false;
export const isFirefox = hasDom ? /Firefox|FxiOS/.test(userAgent) : false;
export const isIE = hasDom
? typeof MSInputMethodContext !== 'undefined' && typeof documentMode !== 'undefined'
: false;