[DOC] Document helper and modifier keywords
#20119
Conversation
|
This is mostly copy-paste from the respective RFC https://github.com/emberjs/rfcs/blob/master/text/0432-contextual-helpers.md and could be a good starting point to land the docs and we may iterate and polish as we go. would appreciate feedback/recommendations |
SergeAstapov
force-pushed
the
document-helper-modifier
branch
from
1cbd4d8
to
650d862
Compare
There was a problem hiding this comment.
Broadly 👍🏼 from me.
I think we can quibble on whether the examples copied from the RFCs are actually useful for explaining what the feature is. In the RFC they are more geared towards exhausting most of the possibilities, in a spec-by-examples kind of way. In documentation that may be a bit much and the point kind of gets lost. In other words, we may want to trim it down so that we only have one or two succinct/common use cases that gets the main point across.
That being said, any docs are certainly better than no docs. So if @SergeAstapov wants to do another pass now I think that's great, but otherwise we can also just merge it and let someone else iterate on this another time.
SergeAstapov
force-pushed
the
document-helper-modifier
branch
from
650d862
to
2f2ee62
Compare
I actually did that originally but then decided to provide exhaustive list examples. trimmed down to 3 examples for both |
SergeAstapov
force-pushed
the
document-helper-modifier
branch
from
2f2ee62
to
d75a0cb
Compare
| that it can be passed around as first-class values in templates. | ||
|
|
||
| ```handlebars | ||
| {{#let (helper "join-words" "foo" "bar" separator=" ") as |foo-bar|}} |
There was a problem hiding this comment.
One more thing (same for the other snippet): foo-bar is it actually legal to have a dash in the local variable (block param) name? I probably should know this but I don't 🙃
There was a problem hiding this comment.
According to AST explorer it seems to be fine so that's good enough for me
Closes #19925