-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Type export experimentation #20003
Conversation
56dc9a7
to
49d5ad0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Couple of nits from the modules affected, will deeply-read-and-understand build-docs.js
next.
packages/@ember/-internals/glimmer/lib/component-managers/curly.ts
Outdated
Show resolved
Hide resolved
46de6a4
to
cc3f254
Compare
94df899
to
8d62688
Compare
I see a lot of conflicts. Has the work been done elsewhere? |
Is this still relevant? It is a draft PR |
I believe this was superceded in its entirety by #20449 (as well as the foundational PRs which preceded it); this was Peter's admirable first pass at trying to get types publishing, and was invaluable prior art in informing the Ember TypeScript team that we were going to have to do the absolute shenanigans that we did in #20449 to get things published. Closing accordingly! |
Includes #20090