Refactor owner #19967
Merged
Refactor owner #19967
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chriskrycho
approved these changes
Feb 11, 2022
💙|
|
||
| import EngineInstance from '@ember/engine/instance'; | ||
| import { TypeOptions } from '../container/lib/registry'; | ||
| // A combination of the public methods on ContainerProxyMixin and RegistryProxyMixin |
There was a problem hiding this comment.
As a next step (doesn't need to be in this PR, but is related to #19916), we should add docs for all of these bits of public API.
That in turn will let us expose a copy of these types in DefinitelyTyped, which will unblock folks between now and when we publish these.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.