More TS #19964
More TS #19964
Conversation
|
This will need to be cleaned up before merging. |
| @@ -77,7 +81,7 @@ const VALID_FULL_NAME_REGEXP = /^[^:]+:[^:]+$/; | |||
| */ | |||
| export default class Registry implements IRegistry { | |||
| readonly _failSet: Set<string>; | |||
| resolver: Resolver | (Resolve & NotResolver) | null; | |||
| resolver: Resolver | null; | |||
There was a problem hiding this comment.
This seems like it is probably incorrect.
There was a problem hiding this comment.
Noting how it works on line 64, are we sure it's not right? (It's certainly weird, and I don't know the runtime code here at all so I'll defer to you on the judgment call.)
There was a problem hiding this comment.
Probably deserves a more careful look at least!
| @@ -3144,7 +3144,7 @@ Clearly, `component-a` has subscribed to `some-other-component`'s `action`. Prev | |||
| * CollectionView context is now its content | |||
| * Various enhancements to bound helpers: adds multiple property support to bound helpers, adds bind-able options hash properties, adds {{unbound}} helper support to render unbound form of helpers. | |||
| * Add App.inject | |||
| * Add Ember.EnumberableUtils.intersection | |||
| * Add Ember.EnumerableUtils.intersection | |||
| @@ -77,7 +81,7 @@ const VALID_FULL_NAME_REGEXP = /^[^:]+:[^:]+$/; | |||
| */ | |||
| export default class Registry implements IRegistry { | |||
| readonly _failSet: Set<string>; | |||
| resolver: Resolver | (Resolve & NotResolver) | null; | |||
| resolver: Resolver | null; | |||
There was a problem hiding this comment.
Noting how it works on line 64, are we sure it's not right? (It's certainly weird, and I don't know the runtime code here at all so I'll defer to you on the judgment call.)
| @public | ||
| */ | ||
| resolver: null, | ||
| declare resolver: Resolver; |
There was a problem hiding this comment.
Given it's set in the constructor, shouldn't need the declare here.
| declare resolver: Resolver; | |
| resolver: Resolver; |
| if (!reason) return; | ||
|
|
||
| let withErrorThrown = reason as ReasonWithErrorThrown; | ||
| if (withErrorThrown?.errorThrown) { |
There was a problem hiding this comment.
Optional chaining not needed here given the !reason check on line 42.
| if (withErrorThrown?.errorThrown) { | |
| if (withErrorThrown.errorThrown) { |
| // eslint-disable-next-line @typescript-eslint/no-empty-interface | ||
| interface ActionHandler {} | ||
| declare const ActionHandler: Mixin; |
There was a problem hiding this comment.
Will presumably need a rebase now that #19948 has also updated this?
| import { Mixin } from '@ember/-internals/metal'; | ||
|
|
||
| interface PromiseProxyMixin<T> { | ||
| reason: null; |
There was a problem hiding this comment.
The default value is presumably null but this would make it so you can't use anything but null. From the docs, I think it should be unknown?
| reason: null; | |
| reason: unknown; |
No description provided.