Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DONT BACKPORT][BUGFIX lts] Ensures that computed can depend on dynamic hash keys #19565

Merged
merged 1 commit into from
May 27, 2021

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented May 27, 2021

Ensures that computeds can depend on dynamic hash keys that did not
exist on the original hash.

Depends on: glimmerjs/glimmer-vm#1318
Fixes: #19562


This PR/fix ended up not working out, so we're not backporting

Ensures that computeds can depend on dynamic hash keys that did not
exist on the original hash.
@pzuraq pzuraq force-pushed the bugfix/ensure-hash-works-with-computeds branch from 167be20 to 628a928 Compare May 27, 2021 15:33
@rwjblue rwjblue merged commit b4ace38 into master May 27, 2021
@rwjblue rwjblue deleted the bugfix/ensure-hash-works-with-computeds branch May 27, 2021 16:16
@pzuraq pzuraq changed the title [BUGFIX lts] Ensures that computed can depend on dynamic hash keys [DONT BACKPORT][BUGFIX lts] Ensures that computed can depend on dynamic hash keys Jun 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants