Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve internal types #19517

Merged
merged 4 commits into from
May 24, 2021
Merged

Improve internal types #19517

merged 4 commits into from
May 24, 2021

Commits on Apr 30, 2021

  1. Remove some unnecessary use of reopen in Route

    @wagenet
    wagenet committed Apr 30, 2021
    Configuration menu
    Copy the full SHA
    ba337bb View commit details
    Browse the repository at this point in the history

Commits on May 24, 2021

  1. Improve types for @ember/object 

    Includes:
  - Object, { action } from '@ember/object'
  - CoreObject from '@ember/object/core'
  - Observable from '@ember/object/observable'

Note that types for `extend`, `reopen`, and `reopenClass` are not
exported. Also, `get` and `set` have naive types. All of these will
be deprecated in future releases.
    @wagenet
    wagenet committed May 24, 2021
    Configuration menu
    Copy the full SHA
    d8f28f4 View commit details
    Browse the repository at this point in the history

  2. Add test for @ember/object/compat types

    @wagenet
    wagenet committed May 24, 2021
    Configuration menu
    Copy the full SHA
    7985ddb View commit details
    Browse the repository at this point in the history

  3. Further improve types per feedback

    @wagenet
    wagenet committed May 24, 2021
    Configuration menu
    Copy the full SHA
    f5f8213 View commit details
    Browse the repository at this point in the history