Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LTS fix] only return empty href when LinkTo href generation throws error #19395

Merged
merged 2 commits into from
Feb 11, 2021
Merged

[LTS fix] only return empty href when LinkTo href generation throws error #19395

merged 2 commits into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. fix: only return empty href when LinkTo href generation throws error 

    In 3.24.0-3.24.2 we made changes to let LinkTo href generation returns
empty when initial transition is not started. This is not true and
causing regression on the super-rental tutorial.

In previous tutorials, the LinkTo component will return empty href when
`this.owner.setupRouter()` is not called. It generates valid href if
`setupRouter()` is called and complete model are passed for dynamic
segments.

In our previous changes, we removed the requirement to call
`setupRouter`, and always return empty href when initial transition is
not started. This is not expected when passing complete dynamic segments
without initial transition.
    @xg-wang
    xg-wang committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    9dbcb7d View commit details
    Browse the repository at this point in the history

  2. avoid try/catch when transition started

    @xg-wang
    xg-wang committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    af4a1b4 View commit details
    Browse the repository at this point in the history