New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate implicit `this` property lookup fallback #19371

Merged

rwjblue merged 1 commit into master from deprecate-this-fallback

Feb 2, 2021

Commits on Feb 2, 2021

Deprecate implicit this property lookup fallback

Lands the deprecation proposed in
[emberjs/rfcs#308](https://github.com/emberjs/rfcs/blob/master/text/0308-deprecate-property-lookup-fallback.md):

The
[no-implicit-this](https://github.com/ember-template-lint/ember-template-lint/blob/master/docs/rule/no-implicit-this.md)
template linting rule has been enabled for Ember applications by default
since around Ember 3.16 (included in the `octane` preset).

This PR will take that a step further and issue a deprecation for
templates that are still using `{{foo}}` to mean `{{this.foo}}`.

Note: It does provide for an easy way to temporarily disable the
deprecation messages (e.g. to reduce console output to hone in on other
issues). This is intended for sporadic usage while debugging **not** as
a way to mitigate the deprecation (the fallback behavior will be
removed in 4.0.0).

rwjblue committed Feb 2, 2021