Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX beta] Ensure locals do not clobber components of the same name #19351

Merged
merged 1 commit into from
Jan 22, 2021

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Jan 21, 2021

Updates glimmer-vm to include glimmerjs/glimmer-vm#1253.

Fixes #19334

@rwjblue rwjblue force-pushed the fix-block-param-symbol-collision branch from 303cd7c to 2404dfc Compare January 21, 2021 16:52
@rwjblue rwjblue changed the title Ensure local block params are not "resolved" [BUGFIX beta] Ensure local block params are not "resolved" Jan 21, 2021
@rwjblue rwjblue added the Bug label Jan 21, 2021
@chancancode
Copy link
Member

Do we need a test?

I think basically:

  1. register a component called foo (e.g. template: "foo component")
  2. have a block param called |foo| (e.g. a string literal "foo block param")
  3. Invoke <Foo /> inside the block (should render "foo component" instead of "foo block param")

@rwjblue rwjblue force-pushed the fix-block-param-symbol-collision branch from 2404dfc to a1b70d1 Compare January 22, 2021 22:16
@rwjblue
Copy link
Member Author

rwjblue commented Jan 22, 2021

Ya, good call. Added the test now.

@rwjblue rwjblue changed the title [BUGFIX beta] Ensure local block params are not "resolved" [BUGFIX beta] Ensure locals do not clobber components of the same name Jan 22, 2021
@rwjblue rwjblue merged commit 7ad44a6 into master Jan 22, 2021
@rwjblue rwjblue deleted the fix-block-param-symbol-collision branch January 22, 2021 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug beta] angle bracket invocation incorrectly shadowed by local variable with different case
2 participants