[BUGFIX lts] Ensure Component Lookup Is Well Formed #19336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces an assertion during the component name refinement to
assert that the lookup syntax is well formed. If a developer
accidentally types ":" instead of "::" you will end up with a runtime
erorr that looks like:
```
Uncaught Error: Assertion Failed: fullName must be a proper full name
at assert (vendor.js:52729)
at Container.lookup (vendor.js:16581)
at Class.lookup (vendor.js:43950)
at layoutFor (vendor.js:28680)
at lookupComponentPair (vendor.js:28697)
at lookupComponent (vendor.js:28711)
at RuntimeResolver._lookupComponentDefinition (vendor.js:28992)
at RuntimeResolver.lookupComponentHandle (vendor.js:28837)
at CompileTimeLookup.lookupComponentDefinition (vendor.js:25065)
at LazyCompiler.resolveLayoutForTag (vendor.js:60366)
```
This message is not actionable for developers. This PR will causes a
compile time error to occur with the following information:
```
Malformed component lookup in "test.js". Got <Foo:Bar \/> but you must use \"::\" to indicate a lookup
```
chadhietala
force-pushed
the
throw-on-invalid-lookup-syntax
branch
from
6b6519e
to
ba57d78
Compare
rwjblue
approved these changes
Jan 12, 2021
rwjblue
changed the title
chancancode
reviewed
Jan 13, 2021
Co-authored-by: Godfrey Chan <[email protected]>
chadhietala
force-pushed
the
throw-on-invalid-lookup-syntax
branch
from
aa56f78
to
c874f15
Compare
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces an assertion during the component name refinement to
assert that the lookup syntax is well formed. If a developer
accidentally types ":" instead of "::" you will end up with a runtime
erorr that looks like:
This message is not actionable for developers. This PR will causes a
compile time error to occur with the following information: