Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lazily setup the router in non-application tests for <LinkTo> component #19326

Merged
merged 4 commits into from
Jan 13, 2021

Conversation

xg-wang
Copy link
Contributor

@xg-wang xg-wang commented Dec 29, 2020

Summary

PR #19080 fixed the issue where accessing public router service throwing
error, however, the PR did not support LinkTo component which uses the
internal -routing service. This PR adds similar lazy setup to
-routing.router.

Todo

PR emberjs#19080 fixed the issue where accessing public router service throwing
error, however, the PR did not support LinkTo component which uses the
internal -routing service. This PR adds similar lazy setup to
-routing.router.
@xg-wang
Copy link
Contributor Author

xg-wang commented Jan 4, 2021

@dstiers11 @rwjblue can we get this PR merged?

@rwjblue rwjblue merged commit 8816a25 into emberjs:master Jan 13, 2021
@rwjblue
Copy link
Member

rwjblue commented Jan 13, 2021

Thank you!

@xg-wang xg-wang deleted the link-to-router-fix branch January 14, 2021 04:22
xg-wang added a commit to xg-wang/super-rentals-tutorial that referenced this pull request Jan 18, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang added a commit to xg-wang/super-rentals-tutorial that referenced this pull request Feb 10, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang added a commit to xg-wang/super-rentals-tutorial that referenced this pull request Feb 10, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang added a commit to xg-wang/super-rentals-tutorial that referenced this pull request Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands in the next release (should be 3.25.0, but I could be wrong)
xg-wang added a commit to xg-wang/super-rentals-tutorial that referenced this pull request Mar 8, 2021
This is no longer needed when emberjs/ember.js#19326 lands
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants