Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates the VM in order to upstream built-ins #19317

Merged
merged 1 commit into from
Dec 20, 2020

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Dec 18, 2020

Updates to to the latest VM version, and upstreams various built-in
keywords and modifiers. The majority of tests have been kept, but tests
which tested assertions have been removed as equivalent tests exist in
Glimmer VM now, and they introduce extra overhead without increasing
test coverage.

Release notes for the VM: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.73.0

Updates to to the latest VM version, and upstreams various built-in
keywords and modifiers. The majority of tests have been kept, but tests
which tested assertions have been removed as equivalent tests exist in
Glimmer VM now, and they introduce extra overhead without increasing
test coverage.
@Alonski
Copy link
Member

Alonski commented Jul 19, 2022

Wanted to say that this changed causes an "issue" with the docs where they no longer point to the actual source code for various things, for example built in helpers.
Docs for fn helper: https://api.emberjs.com/ember/4.4/classes/Ember.Templates.helpers/methods/fn?anchor=fn
Clicking to the source (Defined in) takes me to:
https://github.com/emberjs/ember.js/blob/v4.4.2/packages/%40ember/-internals/glimmer/lib/helpers/fn.ts#L5
Which isn't correct. That is "just" the types.
The source is now here:
https://github.com/glimmerjs/glimmer-vm/blob/master/packages/@glimmer/runtime/lib/helpers/fn.ts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants