[FEATURE strict-mode] Enable classic component usage in strict mode #19306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
approved these changes
Dec 14, 2020
pzuraq
force-pushed
the
update/bump-vm-enable-strict-classic
branch
2 times, most recently
from
a3dc26f to
d81b0f8
Compare
Previously classic components were not possible to use in strict mode, since there was no way to pass the owner to them as they were not resolved with the factory system. This refactor fixes this by using the new owner API, which passes the owner into the `create` hook of component managers. In addition, makes the `renderer` property of views a standard injection that is lazy, so we are no longer injecting it via the implicit injection API.
pzuraq
force-pushed
the
update/bump-vm-enable-strict-classic
branch
from
d81b0f8 to
8072096
Compare
This was referenced Mar 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously classic components were not possible to use in strict mode,
since there was no way to pass the owner to them as they were not
resolved with the factory system. This refactor fixes this by using the
new owner API, which passes the owner into the
createhook ofcomponent managers. In addition, makes the
rendererproperty of viewsa standard injection that is lazy, so we are no longer injecting it via
the implicit injection API.
Release notes for Glimmer VM: https://github.com/glimmerjs/glimmer-vm/releases/tag/v0.70.0