Enforce usage of capabilities generation.
#19173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
force-pushed
the
force-capabilities-usage
branch
from
1f18ada
to
c76e288
Compare
rwjblue
force-pushed
the
force-capabilities-usage
branch
from
c76e288
to
a2f0dc1
Compare
pzuraq
reviewed
Sep 30, 2020
| @@ -17,6 +18,8 @@ const COMPONENT_MANAGERS = new WeakMap< | |||
| ManagerFactory<ComponentManagerDelegate<unknown> | InternalComponentManager> | |||
| >(); | |||
|
|
|||
| const FROM_CAPABILITIES = DEBUG ? new WeakSet() : undefined; | |||
There was a problem hiding this comment.
Doesn't look like the WeakSet polyfill is being used here, may be why browserstack is failing
There was a problem hiding this comment.
Nice, thanks for catching that!
pzuraq
approved these changes
Sep 30, 2020
Prior to this change it was possible to avoid using a given type's
`capabilities` builder function (intentionally or on accident) by doing
something like:
```js
class MyManager {
capabilities = {
// magical properties from Ember's internals
}
}
```
The API's that we _intended_ folks to be using is something like:
```js
import { capabilties as modifierCapabilities } from '@ember/modifier';
class MyManager {
capabilities = modifierCapabilities('3.22');
}
```
This commit ensures that Ember's own internal structures can not be
"spoofed" (avoiding our constraints, or creating a frankenstein
manager).
rwjblue
force-pushed
the
force-capabilities-usage
branch
from
a2f0dc1
to
f776ac8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this change it was possible to avoid using a given type's
capabilitiesbuilder function (intentionally or on accident) by doing something like:The API's that we intended folks to be using is something like:
This commit ensures that Ember's own internal structures can not be "spoofed" (avoiding our constraints, or creating a frankenstein manager).