Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[REFACTOR] Split managers into multiple maps #19159

Merged
merged 1 commit into from
Sep 27, 2020
Merged

[REFACTOR] Split managers into multiple maps #19159

merged 1 commit into from
Sep 27, 2020

Commits on Sep 27, 2020

  1. [REFACTOR] Split managers into multiple maps 

    This refactors managers to split different types of managers into
different maps per-type. This allows more than one type of manager to
be associated with a given definition. For instance, this is a useful
capability for helper and modifier managers to have, since helpers and
modifiers have a lot in common and may end up being able to share
implementations.

This also upstreams the deduplication logic from Glimmer.js, which was
more stringent than in Ember. In Ember, we currently create one instance
of a given manager _per-component-definition_, whereas in Glimmer.js, we
create one _per-factory/owner combination_. Given that managers are
generally encouraged to be mostly-stateless in general, this change
shouldn't be a problem, and should be slightly more performant in apps
with many component definitions.
    Chris Garrett committed Sep 27, 2020
    Configuration menu
    Copy the full SHA
    cce03c2 View commit details
    Browse the repository at this point in the history