[BUGFIX beta] Pass resolver to Test app in generated initializer test #19087
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
requested changes
Aug 7, 2020
rwjblue
reviewed
Aug 7, 2020
node-tests/fixtures/initializer-test/module-unification/rfc232.js
Outdated
Show resolved
Hide resolved
node-tests/fixtures/instance-initializer-test/module-unification/rfc232.js
Outdated
Show resolved
Hide resolved
The default resolver (the globals resolver is deprecated), so we always need to pass this in. Closes emberjs#19046
rwjblue
changed the title
rwjblue
approved these changes
Aug 7, 2020
|
Awesome, thanks for working on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The default resolver (the globals resolver is deprecated), so we
always need to pass this in.
Closes #19046