[FEATURE] Add @ember/destroyable feature. #19062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pzuraq
approved these changes
Jul 30, 2020
The primary implementation happened upstream in Glimmer itself, this is adding API docs and module exports to be used.
rwjblue
force-pushed
the
add-destroyables-api
branch
from
c4c56f9
to
2e19e0d
Compare
This was referenced Jul 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary implementation happened upstream in Glimmer itself, this is adding API docs and module exports to be used.
This is largely copy / pasted from @pzuraq's prose over in emberjs/rfcs#580 (any mistakes are my own 😄 ).