[BUGFIX beta] Updates Glimmer VM to 0.54.0 #19025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisselden
reviewed
Jun 23, 2020
| return engine; | ||
| } | ||
| getDestroyable(bucket: EngineState): Option<Destroyable> { | ||
| return bucket.engine; |
There was a problem hiding this comment.
I assume the controller is a child of the engine and is registered to it
There was a problem hiding this comment.
Yes, based on the code prior to this, I believe that must have been true. This is effectively the equivalent to the code it's replacing.
rwjblue
reviewed
Jun 23, 2020
rwjblue
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the VM to the latest version, incorporating the changes for destroyables. This PR does not add any new public APIs to Ember, the plan is to do that in a followup.