[Chore]: Add integration test for accessing a property during init #19009
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snewcomer
force-pushed
the
sn/test-19003
branch
2 times, most recently
from
d54d327
to
067df9e
Compare
snewcomer
changed the title
|
Failing test - https://travis-ci.org/github/emberjs/ember.js/jobs/700343930 @pzuraq If this integration test for #19023 is useful, this PR is ready for review! |
|
Happy to land this, could you squash down the commits for us? |
|
done! |
rwjblue
approved these changes
Jun 29, 2020
|
Awesome, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #19003
Fixed by #19023