[FEATURE] Adds Cache API #18984
Merged
[FEATURE] Adds Cache API #18984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
May 19, 2020
| @public | ||
| */ | ||
| export function createCache<T>(fn: () => T) { | ||
| return glimmerCreateCache(fn); |
There was a problem hiding this comment.
Can you remind me why we can just export this directly? I know we talked about it, but I can’t recall if we had resolved
There was a problem hiding this comment.
ah, I remember we discussed this actually and it would be fine, any additional arguments are not document so it's fine, I'll update
Adds the cache API specified in RFC 615. Since this API is essentially just exposing the API that was implemented in Glimmer VM, and tested there, I don't think tests are necessary to add in Ember itself.
rwjblue
approved these changes
May 21, 2020
rwjblue
approved these changes
May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the cache API specified in RFC 615. Since this API is essentially
just exposing the API that was implemented in Glimmer VM, and tested there,
I don't think tests are necessary to add in Ember itself.