Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Update glimmer-vm packages to 0.53.0 #18982

Merged
merged 2 commits into from
May 18, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -74,15 +74,15 @@
},
"devDependencies": {
"@babel/preset-env": "^7.9.5",
"@glimmer/compiler": "^0.52.1",
"@glimmer/compiler": "^0.53.0",
"@glimmer/env": "^0.1.7",
"@glimmer/interfaces": "^0.52.1",
"@glimmer/node": "^0.52.1",
"@glimmer/opcode-compiler": "^0.52.1",
"@glimmer/program": "^0.52.1",
"@glimmer/reference": "^0.52.1",
"@glimmer/runtime": "^0.52.1",
"@glimmer/validator": "^0.52.1",
"@glimmer/interfaces": "^0.53.0",
"@glimmer/node": "^0.53.0",
"@glimmer/opcode-compiler": "^0.53.0",
"@glimmer/program": "^0.53.0",
"@glimmer/reference": "^0.53.0",
"@glimmer/runtime": "^0.53.0",
"@glimmer/validator": "^0.53.0",
"@simple-dom/document": "^1.4.0",
"@types/qunit": "^2.9.1",
"@types/rsvp": "^4.0.3",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import {
} from '@glimmer/interfaces';
import { ComponentRootReference, PathReference } from '@glimmer/reference';
import { unwrapTemplate } from '@glimmer/util';
import { consumeTag, createTag, isConst, Tag } from '@glimmer/validator';
import { consumeTag, createTag, isConstTagged, Tag } from '@glimmer/validator';

import { ENV } from '@ember/-internals/environment';
import { EmberVMEnvironment } from '../environment';
Expand Down Expand Up @@ -370,7 +370,7 @@ export default class CustomComponentManager<ComponentInstance>
}

getTag({ args }: CustomComponentState<ComponentInstance>): Tag {
if (isConst(args)) {
if (isConstTagged(args)) {
// returning a const tag skips the update hook (VM BUG?)
return createTag();
} else {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import {
VMArguments,
} from '@glimmer/interfaces';
import { ComponentRootReference, ConstReference, VersionedPathReference } from '@glimmer/reference';
import { CONSTANT_TAG, createTag, isConst } from '@glimmer/validator';
import { CONSTANT_TAG, createTag, isConstTagged } from '@glimmer/validator';
import { EmberVMEnvironment } from '../environment';
import InternalComponentManager, { InternalDefinitionState } from './internal';

Expand Down Expand Up @@ -70,7 +70,7 @@ export default class InputComponentManager extends InternalComponentManager<Inpu
_dynamicScope: DynamicScope,
caller: VersionedPathReference
): InputComponentState {
assert('caller must be const', isConst(caller));
assert('caller must be const', isConstTagged(caller));

let type = args.named.get('type');

Expand Down
4 changes: 2 additions & 2 deletions packages/@ember/-internals/glimmer/lib/helpers/action.ts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ import { join } from '@ember/runloop';
import { DEBUG } from '@glimmer/env';
import { VM, VMArguments } from '@glimmer/interfaces';
import { VersionedPathReference } from '@glimmer/reference';
import { isConst } from '@glimmer/validator';
import { isConstTagged } from '@glimmer/validator';
import { UnboundRootReference } from '../utils/references';
import { INVOKE } from './mut';

Expand Down Expand Up @@ -299,7 +299,7 @@ export default function(args: VMArguments, vm: VM): UnboundRootReference<Functio

if (typeof action[INVOKE] === 'function') {
fn = makeClosureAction(action, action, action[INVOKE], processArgs, debugKey);
} else if (isConst(target) && isConst(action)) {
} else if (isConstTagged(target) && isConstTagged(action)) {
fn = makeClosureAction(context.value(), target.value(), action.value(), processArgs, debugKey);
} else {
fn = makeDynamicClosureAction(context.value(), target, action, processArgs, debugKey);
Expand Down
4 changes: 2 additions & 2 deletions packages/@ember/-internals/glimmer/lib/helpers/get.ts
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import {
VersionedPathReference,
} from '@glimmer/reference';
import { NULL_REFERENCE } from '@glimmer/runtime';
import { isConst } from '@glimmer/validator';
import { isConstTagged } from '@glimmer/validator';
import { referenceFromParts } from '../utils/references';

/**
Expand Down Expand Up @@ -98,7 +98,7 @@ export default function(args: VMArguments, vm: VM) {
let sourceReference = args.positional.at(0);
let pathReference = args.positional.at(1);

if (isConst(pathReference)) {
if (isConstTagged(pathReference)) {
// Since the path is constant, we can create a normal chain of property
// references. The source reference will update like normal, and all of the
// child references will update accordingly.
Expand Down
196 changes: 98 additions & 98 deletions yarn.lock
Original file line number Diff line number Diff line change
Expand Up @@ -913,142 +913,142 @@
resolved "https://registry.yarnpkg.com/@ember/edition-utils/-/edition-utils-1.2.0.tgz#a039f542dc14c8e8299c81cd5abba95e2459cfa6"
integrity sha512-VmVq/8saCaPdesQmftPqbFtxJWrzxNGSQ+e8x8LLe3Hjm36pJ04Q8LeORGZkAeOhldoUX9seLGmSaHeXkIqoog==

"@glimmer/compiler@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.52.1.tgz#23cc23691b52740f1e444d6675d2474aea6a0463"
integrity sha512-vYM3XwuxdcqxQItlopckzgXx/Uo4Cv69rfaf6yE/CAw+xt+LUwUx4Ua7TbyWuJa7gBIK5d1DyxzYD7aspfklAQ==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/syntax" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/wire-format" "^0.52.1"
"@glimmer/compiler@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/compiler/-/compiler-0.53.0.tgz#313b2b7138add2d7fb28737b324a5395f076a794"
integrity sha512-Fn/OD4irLHzj1kAtOYK6NDffcEl+nZu8Gg9F3TeKBT3nZJquJc7wL/gydvN34waIEo88o42HpiG1IiXVXdAIrQ==
dependencies:
"@glimmer/interfaces" "^0.53.0"
"@glimmer/syntax" "^0.53.0"
"@glimmer/util" "^0.53.0"
"@glimmer/wire-format" "^0.53.0"
"@simple-dom/interface" "^1.4.0"

"@glimmer/encoder@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.52.1.tgz#6ee8294c56b5a32926f4653849de0693d5062aa5"
integrity sha512-4Nlb6PdB0Nm4S6UiJd5fDjJDRoRzmioqKDyauIccOw0e/E7aOY4/pg8qhdlkLOV+2btfZEY83puEdXibdmsSyQ==
"@glimmer/encoder@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/encoder/-/encoder-0.53.0.tgz#bb9cc47a6dbe6d1d948d72f737879b1a3fa3a01c"
integrity sha512-Xa3Bo+FQIql+qIYEC/JyEm43Fla2yOmTRNIEuCOx/540XcnzWrbYheRg8etH9nbqdI0AWYi/jXPptGKPDzz4AA==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/vm" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/vm" "^0.53.0"

"@glimmer/[email protected]", "@glimmer/env@^0.1.7":
version "0.1.7"
resolved "https://registry.yarnpkg.com/@glimmer/env/-/env-0.1.7.tgz#fd2d2b55a9029c6b37a6c935e8c8871ae70dfa07"
integrity sha1-/S0rVakCnGs3psk16MiHGucN+gc=

"@glimmer/interfaces@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.52.1.tgz#a397af54d913caaaedfac5d0bd161358c1a50f57"
integrity sha512-Sv1RGcvoIzu1dQBth6sB6LN7tI4qRiRZK3LzwsiYGgFllNPKC6aihrWQi+G/vKevwhzrjLgrnjCHR5uTw188mQ==
"@glimmer/interfaces@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/interfaces/-/interfaces-0.53.0.tgz#cb519256b0b446048b4c674c4db00754d796e0d7"
integrity sha512-Jiq4b5XLXc3OJDPlxj+uq3Owu4rl3e6UyApc6Of6EPal48Ync1jhGcsUUOiP0TdNIm6KeFuzwA2mY6rJ7B5IfQ==
dependencies:
"@simple-dom/interface" "^1.4.0"

"@glimmer/low-level@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.52.1.tgz#8fa39f8abab0a3c211e8f0b699fad14d71456dbf"
integrity sha512-caUt3pLhvEYM/o/Q+7SJig7/2SwWtl/dp39xP50OmEBxty4vKYYYvak/07rp+g3ZgQ0vmdYbShZH4NVLSQTTjA==
"@glimmer/low-level@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/low-level/-/low-level-0.53.0.tgz#acbbed3cae9038d497e81b741cacd9f0c9c5952f"
integrity sha512-l46nrSu4Wj1lsQa2wBIZOFPUa9E37HxGSNARs1nl6gRB+vW7n4nNUWZ8tSfTo8jGw2OETxgH+s3HT8HloIkMbw==

"@glimmer/node@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.52.1.tgz#297282751db4949cd00f599328ae63c2018e6dd5"
integrity sha512-8NZ3Xy0yTR9ZkiyAeS+AhRG8RqyqP7c1TdfxcFzj/lp/cHidjAhfvqpZMjRQcKuFHYh890VdLvazDkcuy9jiTA==
"@glimmer/node@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/node/-/node-0.53.0.tgz#5cd92f0fa23364a425219537c1481228083e2ce7"
integrity sha512-Ua15rR+FnXv8gSUsDzOtQAKf5Op4lOc9PvOagTalgiKX2O08JUtwd/MDwiJGIJ31DgOUkitu+6d8bz4V6unTDg==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/runtime" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/runtime" "^0.53.0"
"@glimmer/util" "^0.53.0"
"@simple-dom/document" "^1.4.0"
"@simple-dom/interface" "^1.4.0"

"@glimmer/opcode-compiler@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.52.1.tgz#0563bbbaacb95882ff28ae334a6579646e403e58"
integrity sha512-h+dsnEdvtJmw0Sj/Q1Jbb+M5rhlvh9CQPuYMky3uSKrhwrJm07AqGfNpF+M9KOScL9OMf/dsY9itSTcr5X9tGQ==
dependencies:
"@glimmer/encoder" "^0.52.1"
"@glimmer/interfaces" "^0.52.1"
"@glimmer/program" "^0.52.1"
"@glimmer/reference" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/vm" "^0.52.1"
"@glimmer/wire-format" "^0.52.1"

"@glimmer/program@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.52.1.tgz#39b041463792dc1c6e441cf0ded5d04b951c2b2b"
integrity sha512-rJhjdSTvBNMRi1f24Lakf3MNf7LVmZ/oP0Dp28YC46eoD4hwXirr5FidXUnDTDDz9z1ScKedudfAb8ZOK1U5TA==
dependencies:
"@glimmer/encoder" "^0.52.1"
"@glimmer/interfaces" "^0.52.1"
"@glimmer/util" "^0.52.1"

"@glimmer/reference@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.52.1.tgz#47355e83dbbd5cbdc28e0f100800def6b723db72"
integrity sha512-oX1QuaUBvRAcHsvYlM1eubIKJdhMhVU6QFpuEyImhto08ihTKiB2fAh14txDM+ub3eHFG30I/Yt5E1OZz3LqdA==
"@glimmer/opcode-compiler@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/opcode-compiler/-/opcode-compiler-0.53.0.tgz#96e7a999fefa6c10d8b95202772341d9e453d613"
integrity sha512-P6usfggdDdbKLPWc87Ca4KpvW7e3erLT1wnmLzzJaro8k3Tmy+XK+MW7w3t0//ixeRjpHa3qBH67WYaZtJP5/g==
dependencies:
"@glimmer/encoder" "^0.53.0"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/program" "^0.53.0"
"@glimmer/reference" "^0.53.0"
"@glimmer/util" "^0.53.0"
"@glimmer/vm" "^0.53.0"
"@glimmer/wire-format" "^0.53.0"

"@glimmer/program@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/program/-/program-0.53.0.tgz#ae0ecc6b6131d122cb4862bff4c98b98001c3829"
integrity sha512-bu1mu00BXEpOnmwBnvBNmiO/9Slybfun75T7AhIKRsV79yDGkkjCfIZoT/4I8UBX0D0vKdu5ZHMXWqp8PjEiYw==
dependencies:
"@glimmer/encoder" "^0.53.0"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/util" "^0.53.0"

"@glimmer/reference@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/reference/-/reference-0.53.0.tgz#3ef189259e28de65eb6e781add27c62d1475ac58"
integrity sha512-wLiUQJ2RrjrwfR3sbbXp6aAmAZpbSmx/q2xk/LDd8Sa9D3hD0FhWeLg/nc7qOxo5USAOYu+5npP2LMuT4nAB0g==
dependencies:
"@glimmer/env" "^0.1.7"
"@glimmer/interfaces" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/validator" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/util" "^0.53.0"
"@glimmer/validator" "^0.53.0"

"@glimmer/runtime@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.52.1.tgz#a11d95d4bb493a691eb4b68435a0f94ec0ce2582"
integrity sha512-Jgq4IXNJUFrRldxw682+l1xoFrF1Z5etQSKfTzIPRg4y6llN+lR6LsDKxqdJu77SmilKfYPoEtYKTa3kPAesFA==
"@glimmer/runtime@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/runtime/-/runtime-0.53.0.tgz#eb48638c8538a2a38f19eb1f0f85cffacd57fa63"
integrity sha512-ucHa0vFYI/hGSPydGhOoG8dplPNFc5jrG+nwxZJyfRnJEsNNTX8ygmqfYjst9Go7XLfGGTXy+kFRtyXPG4RTUg==
dependencies:
"@glimmer/env" "0.1.7"
"@glimmer/interfaces" "^0.52.1"
"@glimmer/low-level" "^0.52.1"
"@glimmer/program" "^0.52.1"
"@glimmer/reference" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/validator" "^0.52.1"
"@glimmer/vm" "^0.52.1"
"@glimmer/wire-format" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/low-level" "^0.53.0"
"@glimmer/program" "^0.53.0"
"@glimmer/reference" "^0.53.0"
"@glimmer/util" "^0.53.0"
"@glimmer/validator" "^0.53.0"
"@glimmer/vm" "^0.53.0"
"@glimmer/wire-format" "^0.53.0"
"@simple-dom/interface" "^1.4.0"

"@glimmer/syntax@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.52.1.tgz#7817fcb67c366b96d6bf7e8c4f732ae172167339"
integrity sha512-j5QdWiVDeNGIxz/dxE14olqc0tQB2ZI/wulCZca0fHhWWPukvQBl+8Hr0LOyo8NRrfxA7Y5z5ZAxnn8SwY5o0A==
"@glimmer/syntax@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/syntax/-/syntax-0.53.0.tgz#61f2dd848aae7644c16f649d2ed0bb1d42c1c0fe"
integrity sha512-j1kXXXlb1+UrmQG6J1b6lByedFEX24zZskvqBxEcrbnwfuvRYf/LYspKlV8MCJIJLbhJCzesMsDBPdYF6IcgyA==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/util" "^0.53.0"
handlebars "^4.7.4"
simple-html-tokenizer "^0.5.9"

"@glimmer/util@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.52.1.tgz#2689fe8c8a09742a5bc8c2abc0a9e0f9bfb28a42"
integrity sha512-wVvFEjjUmK6H4ILl8FGldro8rRAYRxBVnWVkir9GHoLdW3x8vnvpKDQIopOAOJy5QO5Nk3mgSeIz7oMerIonlw==
"@glimmer/util@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/util/-/util-0.53.0.tgz#19375e75c5d248d77b0f751a5f1808c7a23f77a8"
integrity sha512-J/46gQRLe09viNS9/bAvsEOeu70ZfFqKEU4sM9TxeMjNiiWJIN+mPoC3bFG9Ub4pPrmfbIqPOr7lTtBDibB2Sw==
dependencies:
"@glimmer/env" "0.1.7"
"@glimmer/interfaces" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@simple-dom/interface" "^1.4.0"

"@glimmer/validator@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.52.1.tgz#4f4e7dba2ec9d550209f6b6bac06fd90d8d6ead0"
integrity sha512-Fv8zpzewjzii5yIraJdwxx/dQr65Km9sEfpBBYJ4Rn1cgx0ywvmfKNfJGicJw+MY8SpYAwd/ZdnBaojVOcO+ww==
"@glimmer/validator@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/validator/-/validator-0.53.0.tgz#ca9d7565a3ffd187f4c8ed4e315d7f2860ec58bb"
integrity sha512-T40WmR6MTznVq3SYUCOAxsG+G4XOAXAgjZYQQ2x3pRpKQGIDE6ky6BRJ7sChLkZxXjFYyPwOKZtYtIio7gWkLQ==
dependencies:
"@glimmer/env" "^0.1.7"

"@glimmer/vm@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.52.1.tgz#2937795d5f21f81f2bfb9762e14966b886498777"
integrity sha512-hTi4SVBhRy42SQcPVPIj8CdTU0edS59KSA+3FIkgHl69iXKzrrTSqG7N2Q0PN0AoSMFlyOj/jdZQx5ElIUZACw==
"@glimmer/vm@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/vm/-/vm-0.53.0.tgz#09a9b41de17d81e45c13a23dd5a2d29202531753"
integrity sha512-1zP1s2N4dqXDRBWX/AGGH5NoLzC5U5y2dFn4w+v9NUHTeTFMpTgYn4bvNk1RzZBy9CFfnCvBk/4No/KRbq5ZEA==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/util" "^0.53.0"

"@glimmer/wire-format@^0.52.1":
version "0.52.1"
resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.52.1.tgz#8c226a28df1e3063ecc0fba5d8f06563b35df59f"
integrity sha512-ycsoxcwOfvqxAX+T9OR0Ldz9lwFO2AZifVT3x34D+4rR2Rjw5GOsrMBDHNSfiga3/cBrlryEPsnXWcVzbZyV8A==
"@glimmer/wire-format@^0.53.0":
version "0.53.0"
resolved "https://registry.yarnpkg.com/@glimmer/wire-format/-/wire-format-0.53.0.tgz#93dd32ffc6f4a03f1ede57801931d191a8af6293"
integrity sha512-BtFAjCQy1/eEPs0soRV87WqK4g65KpL0f0S1FwUEZdpRocnNdbHI971Xk5N24nCRkuRwfjfXwIVpWw2hz6dVwg==
dependencies:
"@glimmer/interfaces" "^0.52.1"
"@glimmer/util" "^0.52.1"
"@glimmer/interfaces" "^0.53.0"
"@glimmer/util" "^0.53.0"

"@simple-dom/document@^1.4.0":
version "1.4.0"
Expand Down