Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "improve fn & on undefined callback message" #18870

Merged
merged 1 commit into from
Apr 13, 2020
Merged

Conversation

rwjblue
Copy link
Member

@rwjblue rwjblue commented Apr 13, 2020

This reverts the changes from #18353.

The changes landed cause failures in CI (I should have rebased the branch to make sure that the code still worked after the last few glimmer-vm updates).

[0413/140947.176661:INFO:CONSOLE(52)] "    Failed assertion: Promise rejected during " model is tracked": args.positional.at(...).debug is not a function
TypeError: args.positional.at(...).debug is not a function
    at OnModifierState.updateFromArgs (http://localhost:13141/tests/ember.js:9767:68)
    at OnModifierManager.install (http://localhost:13141/tests/ember.js:10002:13)
    at TransactionImpl.commit (http://localhost:13141/tests/ember.js:48873:19)
    at EnvironmentImpl.commit (http://localhost:13141/tests/ember.js:49009:19)
    at inTransaction (http://localhost:13141/tests/ember.js:49167:13)
    at InteractiveRenderer._renderRoots (http://localhost:13141/tests/ember.js:11540:37)
    at InteractiveRenderer._renderRootsTransaction (http://localhost:13141/tests/ember.js:11601:14)
    at InteractiveRenderer._renderRoot (http://localhost:13141/tests/ember.js:11527:12)
    at InteractiveRenderer._appendDefinition (http://localhost:13141/tests/ember.js:11442:12)
    at InteractiveRenderer.appendOutletView (http://localhost:13141/tests/ember.js:11428:12)", source:  (52)

This reverts commit f6f9f52.

The changes landed cause failures in CI (I should have rebased the
branch to make sure that the code still worked after the last few
glimmer-vm updates).

```
[0413/140947.176661:INFO:CONSOLE(52)] "    Failed assertion: Promise rejected during " model is tracked": args.positional.at(...).debug is not a function
TypeError: args.positional.at(...).debug is not a function
    at OnModifierState.updateFromArgs (http://localhost:13141/tests/ember.js:9767:68)
    at OnModifierManager.install (http://localhost:13141/tests/ember.js:10002:13)
    at TransactionImpl.commit (http://localhost:13141/tests/ember.js:48873:19)
    at EnvironmentImpl.commit (http://localhost:13141/tests/ember.js:49009:19)
    at inTransaction (http://localhost:13141/tests/ember.js:49167:13)
    at InteractiveRenderer._renderRoots (http://localhost:13141/tests/ember.js:11540:37)
    at InteractiveRenderer._renderRootsTransaction (http://localhost:13141/tests/ember.js:11601:14)
    at InteractiveRenderer._renderRoot (http://localhost:13141/tests/ember.js:11527:12)
    at InteractiveRenderer._appendDefinition (http://localhost:13141/tests/ember.js:11442:12)
    at InteractiveRenderer.appendOutletView (http://localhost:13141/tests/ember.js:11428:12)", source:  (52)
```
@rwjblue rwjblue merged commit afa3eb6 into master Apr 13, 2020
@rwjblue rwjblue deleted the fix-master branch April 13, 2020 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant