Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Add support for public in-element #18867

Merged
merged 5 commits into from
Apr 11, 2020

Conversation

simonihmig
Copy link
Contributor

@simonihmig simonihmig commented Apr 10, 2020

As per RFC287.

  • This does not yet add API docs, will follow in a separate PR
  • The removal of the hereby deprecated {{-in-element}} is slated for 4.0. The RFC suggested the next version after the next LTS, but given that the deprecation will be added at 3.19 at the earliest, I would think 4.0 seems appropriate (depending on how many more 3.x releases are expected)

@locks
Copy link
Contributor

locks commented Apr 10, 2020

Thank you for the help! I don't think this is wrapped in a feature flag, so I would like to see API documentation be merged with the implementation so we make sure any release with the feature also contains the documentation. I can help with it!

@simonihmig
Copy link
Contributor Author

@locks added a commit with the API docs!

@simonihmig
Copy link
Contributor Author

Travis build itself is green, but still shown here as pending. 🤔

@pzuraq pzuraq changed the title Add support for public in-element [FEATURE] Add support for public in-element Apr 11, 2020
Copy link
Contributor

@pzuraq pzuraq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me! Thanks for getting this done 😄

@pzuraq
Copy link
Contributor

pzuraq commented Apr 11, 2020

Ah, one thing actually, could you add a canary feature flag that guards this? Shouldn't be too hard, it should probably just re-enable the transform that errors for {{in-element}}

@simonihmig
Copy link
Contributor Author

Ah, one thing actually, could you add a canary feature flag that guards this?

@pzuraq done. Hope I got the usage of feature flags right, please re-review!

@@ -20,6 +20,7 @@ export const DEFAULT_FEATURES = {
EMBER_CUSTOM_COMPONENT_ARG_PROXY: true,
EMBER_GLIMMER_SET_COMPONENT_TEMPLATE: true,
EMBER_ROUTING_MODEL_ARG: true,
EMBER_GLIMMER_IN_ELEMENT: null,
Copy link
Contributor

@pzuraq pzuraq Apr 11, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's probably fine to enable by default in this PR too, since it's not a major refactor. The feature flag is mostly to give us a way to turn it off in case we do run into major issues during beta. Will confirm though

Scratch that, we'll bring it up in the next core team meeting to enable, going through the standard process (checked with @rwjblue)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah right. Now that you are mentioning this, I remember that I wanted to ask about this 😝

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, seems I was mistaken. Assuming travis passes I think this is good to go!

@simonihmig
Copy link
Contributor Author

Travis seems to undergo maintenance, the build is not showing up here so far, but it is running here

@pzuraq pzuraq merged commit 4945a71 into emberjs:master Apr 11, 2020
@pzuraq
Copy link
Contributor

pzuraq commented Apr 11, 2020

Thanks again @simonihmig!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants