[BUGFIX] Make ArrayProxy Lazy #18835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR refactors ArrayProxy to only begin observing the proxied array's changes the first time the proxy is actually used. This fixes a number of bugs that have popped up recently, and also ensures that ArrayProxy creation does not accidentally entangle with the autotracking stack. It also simplifies the code overall, and conceptually is more in line with the way that autotracking works. In addition, it adds a CUSTOM_TAG_FOR to the proxy, to forward the `[]` and `length` tags from its content directly rather than attempting to managed them itself. This keeps the system from encountering issues related to tag updates, and from needing to re-notify when changes are propagated. As part of fixing this, I also discovered that the `hasArrayObservers` API has been broken since ~3.11. I fixed it and added a test.
|
Can you cross link the original PR? |
rwjblue
approved these changes
Mar 24, 2020
| @@ -11,14 +11,14 @@ import { | |||
| removeArrayObserver, | |||
| replace, | |||
| getChainTagsForKey, | |||
| tagForProperty, | |||
| CUSTOM_TAG_FOR, | |||
There was a problem hiding this comment.
When did this API land? I just want to make sure it existed in 3.16...
There was a problem hiding this comment.
it landed with one of the more recent bugfixes, and I believe was backported.
rwjblue
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors ArrayProxy to only begin observing the proxied array's
changes the first time the proxy is actually used. This fixes a number
of bugs that have popped up recently, and also ensures that ArrayProxy
creation does not accidentally entangle with the autotracking stack. It
also simplifies the code overall, and conceptually is more in line with
the way that autotracking works.
In addition, it adds a CUSTOM_TAG_FOR to the proxy, to forward the
[]and
lengthtags from its content directly rather than attempting tomanaged them itself. This keeps the system from encountering issues
related to tag updates, and from needing to re-notify when changes are
propagated.
As part of fixing this, I also discovered that the
hasArrayObserversAPI has been broken since ~3.11. I fixed it and added a test.
Original PR: #18770