[BUGFIX lts] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+. #18831

rwjblue · 2020-03-21T23:50:27Z

Due to the way Ember itself is compiled, we have custom versions of the @babel/helpers that we inline into the IIFE that contains Ember. This is obviously pretty unideal (largely because it forces us to be misaligned with Babel and therefore brittle to reasonable changes that they make).

These helpers have been pretty stable for quite a while, but recently Babel 7.9.0 introduced a couple of new helpers:

createSuper allows subclassing from native classes, even when partially transpiled).
createForOfIteratorHelperLoose

Versions of ember-source prior to 3.13 fully transpiled with the Babel version in emberjs/ember.jss own yarn.lock at publish time. The build process was significantly changed in [email protected] so that ember-source would behave just like a normal addon. This was a huge improvement!! Unfortunately, those changes also made us vulnerable to changes made to Babel (new helpers added).

We must resolve that issue (likely by removing these custom external helpers in favor of using includeExternalHelpers from ember-cli-babel), but in the meantime this commit adds the required helpers which should fix the reported issue in supported Ember versions.

Fixes #18827

rwjblue · 2020-03-22T00:09:02Z

Confirmed failure:

Uncaught TypeError: (0 , _emberBabel.createSuper) is not a function
TypeError: (0 , _emberBabel.createSuper) is not a function
    at http://localhost:13141/ember-template-compiler.js:6962:46
    at http://localhost:13141/ember-template-compiler.js:7303:4
    at internalRequire (http://localhost:13141/tests/ember.js:64:14)
    at internalRequire (http://localhost:13141/tests/ember.js:60:22)
    at internalRequire (http://localhost:13141/tests/ember.js:60:22)
    at internalRequire (http://localhost:13141/tests/ember.js:60:22)
    at internalRequire (http://localhost:13141/tests/ember.js:60:22)
    at internalRequire (http://localhost:13141/tests/ember.js:60:22)
    at require (http://localhost:13141/tests/ember.js:97:14)
    at http://localhost:13141/ember-template-compiler.js:17947:92", source:  (52)

Due to the way Ember itself is compiled, we have custom versions of the `@babel/helpers` that we inline into the IIFE that contains Ember. This is obviously pretty unideal (largely because it forces us to be misaligned with Babel and therefore brittle to reasonable changes that they make). These helpers have been pretty stable for quite a while, but recently Babel 7.9.0 introduced a couple of new helpers: * `createSuper` allows subclassing from native classes, even when partially transpiled). * `createForOfIteratorHelperLoose` Versions of `ember-source` prior to 3.13 fully transpiled with the Babel version in `emberjs/ember.js`s _own_ `yarn.lock` at publish time. The build process was significantly changed in `[email protected]` so that `ember-source` would behave just like a normal addon. This was a **huge** improvement!! Unfortunately, those changes also made us vulnerable to changes made to Babel (new helpers added). We **must** resolve that issue (likely by removing these custom external helpers in favor of using `includeExternalHelpers` from `ember-cli-babel`), but in the meantime this commit adds the required helpers which should fix the reported issue in supported Ember versions.

rwjblue · 2020-03-22T01:01:53Z

FYI - These changes will need to be backported for 3.16 (affected LTS), 3.17 (current release), and 3.18 (current beta).

emberjs/ember.js#18827 emberjs/ember.js#18831

Turbo87 · 2020-03-22T20:40:11Z

to avoid such issues in the future would it make sense for use to switch to ~ constraints for Babel?

rwjblue · 2020-03-23T00:35:54Z

to avoid such issues in the future would it make sense for use to switch to ~ constraints for Babel?

@Turbo87 - It would not have made a difference in this case. The drift is from ember-cli-babel itself, I suppose we could pin it with ~ instead of ^ (on @babel/preset-env), but that also seems pretty bad. The real issue is what I described above: we shouldn't "custom override" the babel helpers like this.

rwjblue · 2020-03-23T01:27:22Z

FYI - I've just queued up the CI jobs that will publish 3.17.1 and 3.16.4 (the next beta should be published tomorrow).

To follow along:

3.17.1 will be published by https://travis-ci.org/github/emberjs/ember.js/builds/665660999
3.16.4 will be published by https://travis-ci.org/github/emberjs/ember.js/builds/665686106

If either of these are red, it means the release didn't publish so please ping me and let me know!

rwjblue · 2020-03-23T12:51:08Z

v3.17.1 is published with this fix (should resolve things for folks generating new apps), but I made a mistake when pulling back these changes for 3.16 (just forgot to include the commits when cherry-picking other fixes 🤦‍♂) and v3.16.4 does not include this fix.

I have kicked off a publishing of v3.16.5 (definitely with these changes) and it is working its way through CI now:

https://travis-ci.org/github/emberjs/ember.js/builds/665843150

jherdman · 2020-03-23T17:45:43Z

@rwjblue by any chance has this been upstreamed to beta yet?

rwjblue · 2020-03-23T21:01:27Z

@jherdman - It is in beta branch, but a beta hasn't been tagged / released yet. Should happen today.

jherdman · 2020-03-24T01:07:03Z

Much, love! Thank you so much for all that you do.

poplevente · 2020-03-24T11:40:28Z

@rwjblue do you know when will be published to npm?

rwjblue · 2020-03-24T13:21:27Z

@poplevente - v3.18.0-beta.3 was published yesterday (roughly 17 hours ago).

poplevente · 2020-03-24T13:34:57Z

@rwjblue i don't see that on npmjs

rwjblue · 2020-03-24T15:35:33Z

@poplevente - It is there 😸 https://www.npmjs.com/package/ember-source/v/3.18.0-beta.3

poplevente · 2020-03-25T08:06:43Z

@rwjblue i mean update ember-cli
on our build machine we install ember-cli as a global and that fails now with the error from this ticket

poplevente · 2020-03-25T09:19:14Z

@rwjblue our problem is that we have a project which was running with [email protected]
worked well before a few days ago. now we receive the _createSuper error. if we go to 3.17.1 it works, but we receive errors and warning with deprecation messages.
is there a version we can go back which was similar to the old 3.13? i've tried 3.12.3, and it works, but will it have any impact? or we better do an updage to 3.17.1 and do the deprecation? (which is time and money :( )

rwjblue · 2020-03-25T12:24:20Z

3.13 is unsupported (contains loads of bugs fixed in more recent versions), 3.12 works well and is a supported LTS that is unaffected by the issue this PR fixes (though it does not contain all of the octane features, e.g. tracked).

As far as I see it, you have a few options:

upgrade to supported Ember versions (either 3.16 which is an LTS or 3.17 which is the current release)
downgrade to 3.12 (supported for security fixes for a bit longer)
fix your applications lock file such that you are not picking up Babel 7.9

poplevente · 2020-03-25T12:28:31Z

@rwjblue awesome thanks!

…3.16.0` This should hopefully avoid emberjs/ember.js#18831

Update babel related packages to latest.

485f004

rwjblue added the Bug label Mar 21, 2020

rwjblue requested a review from pzuraq March 22, 2020 00:48

rwjblue changed the title ~~WIP: Update babel related packages to latest.~~ Fix transpilation issues (e.g. _createSuper is not a function) when used with Babel 7.9.0+. Mar 22, 2020

rwjblue mentioned this pull request Mar 22, 2020

(0 , _emberBabel.createSuper) is not a function. Recent babel 7.9.0 seems to break all apps #18827

Closed

rwjblue changed the title ~~Fix transpilation issues (e.g. _createSuper is not a function) when used with Babel 7.9.0+.~~ [BUGFIX lts] Fix transpilation issues (e.g. _createSuper is not a function) when used with Babel 7.9.0+. Mar 22, 2020

locks approved these changes Mar 22, 2020

View reviewed changes

pzuraq approved these changes Mar 22, 2020

View reviewed changes

nickschot added a commit to nickschot/ember-mobile-menu that referenced this pull request Mar 22, 2020

fix ember compilation (see emberjs/ember.js#18831 )

6cc738e

MarcoUmpierrez added a commit to MarcoUmpierrez/fitness that referenced this pull request Mar 22, 2020

Add resolutions to prevent createSuper error

bceb388

emberjs/ember.js#18827 emberjs/ember.js#18831

rwjblue merged commit 8ba9596 into master Mar 23, 2020

rwjblue deleted the update-babel branch March 23, 2020 00:36

This was referenced Mar 23, 2020

fix(deps): update ember to 3.16 adfinis/ember-uikit#413

Closed

fix(deps): update ember to 3.16.5 adfinis/ember-uikit#414

Merged

villander mentioned this pull request Mar 24, 2020

Update project to ember-cli 3.17.0 ember-engines/ember-engines#698

Merged

simonihmig mentioned this pull request Mar 25, 2020

Update to Ember 3.17 ember-bootstrap/ember-bootstrap#1020

Closed

jelhan mentioned this pull request Mar 25, 2020

upgrade ember changeset to v3 ember-bootstrap/ember-bootstrap-changeset-validations#19

Merged

rwjblue mentioned this pull request Mar 30, 2020

Drop support for Node 8 ember-cli/ember-resolver#532

Merged

Turbo87 added a commit to Turbo87/ember-hbs-minifier that referenced this pull request Apr 2, 2020

Adjust Ember.js support matrix to `~3.4.0 || ~3.8.0 || ~3.12.0 || >= …

8521c5e

…3.16.0` This should hopefully avoid emberjs/ember.js#18831

Turbo87 mentioned this pull request Apr 2, 2020

Adjust Ember.js support matrix to ~3.4.0 || ~3.8.0 || ~3.12.0 || >= 3.16.0 mainmatter/ember-hbs-minifier#235

Merged

lolmaus mentioned this pull request Apr 5, 2020

More fixes kaliber5/k5-ember-boilerplate#4

Merged

hjdivad mentioned this pull request Apr 9, 2020

make sure CI is good ember-m3/ember-m3#653

Closed

jkusa mentioned this pull request Apr 15, 2020

Unknown helper createSuper error in build jkusa/ember-cli-clipboard#177

Closed

22a added a commit to 22a/ember-helper-re-render-repro that referenced this pull request May 22, 2020

3.17.1, not working, avoid emberjs/ember.js#18831

fe827a5

dfreeman mentioned this pull request May 29, 2020

Use temp dir in project for precompile typed-ember/ember-cli-typescript#1153

Merged

dfreeman mentioned this pull request Jul 1, 2020

Get CI passing typed-ember/ember-cli-typescript#1167

Merged

mkszepp mentioned this pull request Jan 9, 2023

[Bug] 3.28.x - Error while hide input field on IE11 (Unhandled promise rejection Error: Invalid argument) #20347

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[BUGFIX lts] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+. #18831

[BUGFIX lts] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+. #18831

rwjblue commented Mar 21, 2020 •

edited

Loading

rwjblue commented Mar 22, 2020

rwjblue commented Mar 22, 2020

Turbo87 commented Mar 22, 2020

rwjblue commented Mar 23, 2020

rwjblue commented Mar 23, 2020 •

edited

Loading

rwjblue commented Mar 23, 2020

jherdman commented Mar 23, 2020

rwjblue commented Mar 23, 2020

jherdman commented Mar 24, 2020

poplevente commented Mar 24, 2020

rwjblue commented Mar 24, 2020

poplevente commented Mar 24, 2020

rwjblue commented Mar 24, 2020

poplevente commented Mar 25, 2020

poplevente commented Mar 25, 2020

rwjblue commented Mar 25, 2020

poplevente commented Mar 25, 2020

[BUGFIX lts] Fix transpilation issues (e.g. _createSuper is not a function) when used with Babel 7.9.0+. #18831

[BUGFIX lts] Fix transpilation issues (e.g. _createSuper is not a function) when used with Babel 7.9.0+. #18831

Conversation

rwjblue commented Mar 21, 2020 • edited Loading

rwjblue commented Mar 22, 2020

rwjblue commented Mar 22, 2020

Turbo87 commented Mar 22, 2020

rwjblue commented Mar 23, 2020

rwjblue commented Mar 23, 2020 • edited Loading

rwjblue commented Mar 23, 2020

jherdman commented Mar 23, 2020

rwjblue commented Mar 23, 2020

jherdman commented Mar 24, 2020

poplevente commented Mar 24, 2020

rwjblue commented Mar 24, 2020

poplevente commented Mar 24, 2020

rwjblue commented Mar 24, 2020

poplevente commented Mar 25, 2020

poplevente commented Mar 25, 2020

rwjblue commented Mar 25, 2020

poplevente commented Mar 25, 2020

[BUGFIX lts] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+. #18831

[BUGFIX lts] Fix transpilation issues (e.g. `_createSuper` is not a function) when used with Babel 7.9.0+. #18831

rwjblue commented Mar 21, 2020 •

edited

Loading

rwjblue commented Mar 23, 2020 •

edited

Loading