Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Backport/bugfix query params helpers pr #18458 issue #18076 #18546

Closed
wants to merge 5 commits into from
Closed

Backport/bugfix query params helpers pr #18458 issue #18076 #18546

wants to merge 5 commits into from

Conversation

NullVoxPopuli
Copy link
Sponsor Contributor

thanks @Alonski !

@Alonski @NullVoxPopuli
tests: Add failing test for QP helper with let
5989bfa 
Using (query-params) helper outside of a link-to is incorrectly failing
@Alonski @NullVoxPopuli
fix: Fixed link-to assert with (qp) helper
9b24e5e 
Using (query-params) helper outside of link-to should not throw
@Alonski @NullVoxPopuli
feat: Assert "Cannot pass QPs object in @models and @query at same time
39e2f05
@Alonski @NullVoxPopuli
Revert "feat: Assert "Cannot pass QPs object in @models and @query at…
fa59384 
… same time"

This reverts commit fc7cb2d.
@Alonski
Copy link
Member

Alonski commented Nov 14, 2019

Welcome @NullVoxPopuli ;)

@rwjblue
Copy link
Member

rwjblue commented Nov 15, 2019

Looks like we have one test failure:

Test failed: {{link-to}} component with query-params (rendering): (query-params) must be used in conjunction with `{{link-to}}", source: (49)

@NullVoxPopuli
Copy link
Sponsor Contributor Author

yeah, the bug isn't actually fixed yet, somehow :(

@rwjblue
Copy link
Member

rwjblue commented Nov 15, 2019

@NullVoxPopuli - Hmm, maybe I'm miss reading that message but it seems that the test is specifically stating that (query-params can't be used outside of a link-to (whcih is the thing we fixed!). My suggestion: find the test, confirm its testing the bad behavior, delete the test.

@NullVoxPopuli
Copy link
Sponsor Contributor Author

it's this test: https://github.com/emberjs/ember.js/pull/18546/files#diff-a912b76af52c89d34aee6b496aa64b4dR70 the assertion is being raised incorrectly

@Alonski
Copy link
Member

Alonski commented Nov 16, 2019

@NullVoxPopuli I just opened #18555
This can be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NullVoxPopuli @Alonski @rwjblue