[BUGFIX release] Remove requirement for jquery in Octane #18500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rwjblue
reviewed
Oct 22, 2019
| @@ -79,12 +79,6 @@ module.exports = { | |||
| ); | |||
| } | |||
|
|
|||
| if (optionalFeaturesMissing || optionalFeatures.isFeatureEnabled('jquery-integration')) { | |||
There was a problem hiding this comment.
Instead of removing this, we should ensure that the flag is set (not undefined).
Removes the requirement for disabling Jquery, instead only requiring that users explicitly enable/disable it.
pzuraq
force-pushed
the
bugfix/remove-requirement-for-jquery-in-octane
branch
from
4532a28
to
7a25c08
Compare
rwjblue
approved these changes
Oct 24, 2019
rwjblue
changed the title
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on community feedback and early testing, the core team
has decided that disabling jquery-integration does not need to be a
requirement for enabling Octane mode, so we can remove it from
the error messages.