[BUGFIX beta] Prevent infinite cycles from lazy computed computation #18406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Lazy computed chaining can sometimes lead to infinite cycles that, if a computed property setup has a natural cycle that leads back to the original CP which is finishing its chains. Ensuring the cache and revisions are set _before_ we finish chaining prevents this. Also moves the `set` into the set block, so we don't reset the value if we're returning from cache.
rwjblue
approved these changes
Sep 18, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lazy computed chaining can sometimes lead to infinite cycles that, if a
computed property setup has a natural cycle that leads back to the
original CP which is finishing its chains. Ensuring the cache and
revisions are set before we finish chaining prevents this. Also moves
the
setinto the set block, so we don't reset the value if we'rereturning from cache.