Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Matches assertion behavior for CPs computing after destroy #18222

Merged
merged 2 commits into from
Jul 30, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Jul 30, 2019

Previously, there was an assertion that threw whenever a CP was
calculated after destroy, and updated its dependent keys (i.e.
updated chains). This meant that CPs without any dependencies would
still run after destroy, and everything would work. The new assertion
always threw if anyone accessed any CP. This changes it to only throw
if the CP has dependencies, matching the old behavior.

Previously, there was an assertion that threw whenever a CP was
calculated after destroy, _and_ updated its dependent keys (i.e.
updated chains). This meant that CPs without any dependencies would
still run after destroy, and everything would work. The new assertion
always threw if anyone accessed _any_ CP. This changes it to only throw
if the CP has dependencies, matching the old behavior.
@pzuraq pzuraq force-pushed the bugfix/tracked/match-previous-cp-assertion-behavior branch from 0929dfa to 7892e34 Compare July 30, 2019 21:57
@pzuraq pzuraq merged commit 8179b69 into master Jul 30, 2019
@pzuraq pzuraq deleted the bugfix/tracked/match-previous-cp-assertion-behavior branch July 30, 2019 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants