Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deprecations for mouseEnter/Leave/Move Ember events #18214

Merged
merged 3 commits into from
Jul 26, 2019

Conversation

simonihmig
Copy link
Contributor

As per RFC486

Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking really good!

A few small things:

  • Ensure there is a test for <div {{action 'foo' on={{this.mouseMethod}}></div>?
  • Can we avoid adding these listeners when we do not detect the deprecated situations? Maybe I should modify my other PR to be limited to just these three events (so we can more easily land it)?


deprecate(
`Using the \`{{action}}\` modifier with \`${actionState.eventName}\` events has been deprecated.`,
actionState.eventName !== 'mouseEnter' &&
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm a tad worried about:

<div {{action 'foo' on=this.mouseMethod}}></div>

Do we have a test for that? Does it also emit the deprecation warning?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@simonihmig
Copy link
Contributor Author

Can we avoid adding these listeners when we do not detect the deprecated situations? Maybe I should modify my other PR to be limited to just these three events (so we can more easily land it)?

Seems reasonable to me! (for others, we are talking about #17911)

Either way I think we can/should do it as a separate PR, as this is just concerned about the deprecations, and the other is about optimizations.

@rwjblue rwjblue merged commit e3759ac into emberjs:master Jul 26, 2019
@rwjblue
Copy link
Member

rwjblue commented Jul 26, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants