[BUGFIX beta] Update assertion for events in tagless component to include method names #17930
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raido
force-pushed
the
tagless-event-handlers
branch
from
5130b4a
to
485402a
Compare
rwjblue
reviewed
Apr 16, 2019
raido
force-pushed
the
tagless-event-handlers
branch
from
beccf06
to
94de0c4
Compare
rwjblue
changed the title
|
👍 Closes: #17929 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a take on to tackle issue: #17929 - to make assertion message a bit more explicit by including offending event handler function name in the message itself.
Additionally I wrapped it into DEBUG flag to avoid shipping this to production at all, not sure if this is a right thing to do. If not I can remove the wrap.