[DEPRECATION] Add deprecation for Function.prototype extensions. #17910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
btecu
reviewed
Apr 12, 2019
| false, | ||
| { | ||
| id: 'ember-runtime.function.property', | ||
| until: '4.0.0', |
There was a problem hiding this comment.
Do we also need since: '3.10.0' (or '3.11.0') here?
There was a problem hiding this comment.
No, deprecate's options do not include a since field. The intent is for the @ember/deprecated-features exports to do that, and ultimately be used to enable svelte infrastructure.
rwjblue
force-pushed
the
deprecate-function-prototype-extensions
branch
from
dc70fd7
to
0c1f920
Compare
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements emberjs/rfcs#272.
TODO: