[beta] Revert "[CHORE] Node 6 is EOL this month" #17891
Conversation
|
hmm... why? seems bad to not test what we claim to support 🤔 |
|
Feel free to fix the issue that #17836 was addressing in other ways then... |
|
The CI failure here in this PR is an example of exactly the failure on Node 6: |
"the SIGSEGV bug" is not a very verbose bug description 😉 do we have any information on why this happens, when it started happening, etc? |
|
@Turbo87 unfortunately no, it started showing up and killing all of the builds 😕 I searched around after being blocked for some time, all I could find is that it indicated a segmentation fault, so something fairly low level. No results for Our best guess, and the reason we merged this PR, is that something low level upstream changed in a way that doesn't support Node 6 anymore, since it was being EOL'd. It could be something they knew would break, or something they didn't, we just aren't sure. Our reasoning for this was that by the time Ember 3.10.0 releases, we will not be officially supporting Node v6 anymore, so we reasoned it was not problematic to drop support during beta and unblock our builds. |
|
@pzuraq the problem is that all the addons that follow our blueprint still use Node 6 on CI, but they do test the beta releases of Ember which now causes CI to fail for a lot of addons :-/ |
|
Do you think @rwjblue's solution is good enough for now? We aren't planning on breaking on APIs, haven't made any changes to the distributed files that would cause issues I don't believe |
Turbo87
force-pushed
the
revert-17836-chore/bump-minimum-node-version
branch
from
5d7914e to
02fa397
Compare
Reverts #17836