Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX beta] Prevents autotracking ArrayProxy creation #17834

Merged
merged 1 commit into from
Nov 22, 2019
Merged

[BUGFIX beta] Prevents autotracking ArrayProxy creation #17834

merged 1 commit into from
Nov 22, 2019

Commits on Nov 22, 2019

  1. [BUGFIX] Tracked Props - Prevents autotracking ArrayProxy creation 

    This PR prevents an issue with immediate invalidation within the new
autotracking transaction. ArrayProxy currently reads from one of its
own properties, `hasArrayObservers`, and then immediately updates it
with `notifyPropertyChange`.

We avoid this by using a native descriptor instead of a computed, and
not using `get()` to access it. This way, nothing is tracked during
creation (even if it is mutated).
    Chris Garrett committed Nov 22, 2019
    Configuration menu
    Copy the full SHA
    03c776b View commit details
    Browse the repository at this point in the history