Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE ember-glimmer-angle-bracket-built-ins] #17735

Merged
merged 5 commits into from
Mar 18, 2019
Merged

[FEATURE ember-glimmer-angle-bracket-built-ins] #17735

merged 5 commits into from
Mar 18, 2019

Conversation

chancancode
Copy link
Member

@chancancode chancancode commented Mar 14, 2019 •
edited
Loading

Implementation of emberjs/rfcs#459

  • Remove {{dash-rule}}
  • Implement <Textarea />
    • <TextArea /> => "Did you mean <Textarea />?"
  • Implement <Input />
  • Implement <LinkTo />
  • Update documentation
    • How do we flag it?
    • "helper" -> "component"
      • What is the "namespace" for this?
    • How to show both invocation styles?

@wycats wycats force-pushed the angle-built-ins branch 6 times, most recently from 9f46a9f to 3585ee1 Compare March 16, 2019 01:01
@chancancode
[FEATURE ember-glimmer-angle-bracket-built-ins]
2541268 
Implement `<Textarea />`
@chancancode
[FEATURE ember-glimmer-angle-bracket-built-ins]
96cb49d 
Remove `{{dash-rule}}` for curly invocations.
@chancancode
[FEATURE ember-glimmer-angle-bracket-built-ins]
05472ed 
Implement `<TextArea />` typo guard.
@wycats wycats force-pushed the angle-built-ins branch 2 times, most recently from 27ac173 to 698f7e9 Compare March 16, 2019 23:55
@rwjblue rwjblue changed the title [WIP] [FEATURE ember-glimmer-angle-bracket-built-ins] [FEATURE ember-glimmer-angle-bracket-built-ins] Mar 18, 2019
@rwjblue
Copy link
Member

rwjblue commented Mar 18, 2019

Resolved conflicts, and removed WIP from title.

@chancancode will work on <LinkTo in a separate PR...

@rwjblue rwjblue merged commit c8987af into master Mar 18, 2019
@rwjblue rwjblue deleted the angle-built-ins branch March 18, 2019 19:36
rwjblue added a commit to rwjblue/ember-octane-blueprint that referenced this pull request Mar 18, 2019
@rwjblue
Add angle bracket invocation for built-ins.
0f8ae51 
Feature flag added in emberjs/ember.js#17735.
@rwjblue rwjblue mentioned this pull request Mar 18, 2019
Merged
NullVoxPopuli pushed a commit to ember-cli/ember-octane-blueprint that referenced this pull request Mar 18, 2019
@rwjblue @NullVoxPopuli
Add angle bracket invocation for built-ins. (#80)
28e467d 
Feature flag added in emberjs/ember.js#17735.
@chancancode chancancode mentioned this pull request Mar 20, 2019
Merged
@kategengler kategengler mentioned this pull request Apr 22, 2019
Closed
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chancancode @rwjblue