Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Implements the Computed Property Modifier deprecation RFCs #17470

Merged
merged 2 commits into from
Jan 17, 2019

Conversation

pzuraq
Copy link
Contributor

@pzuraq pzuraq commented Jan 11, 2019

  • Deprecates .property()
  • Deprecates .volatile()
  • Deprecates clobberSet internally
  • Keeps injected properties and the store property on routes
    overridable for testing purposes
  • Rewrites lots of usages in tests. For some reason volatile was
    frequently used in tests when it was not needed.
  • Adds additionalDependentKeys array to map, filter and sort
    array functions. sort was overlooked in RFC, but suffers from the
    same problem so it shouldn't need an additional RFC.
  • Adds tests for additionalDependentKeys

@pzuraq
Copy link
Contributor Author

pzuraq commented Jan 11, 2019

Deprecation doc PR here

- Deprecates `.property()`
- Deprecates `.volatile()`
- Deprecates `clobberSet` internally
- Keeps injected properties and the `store` property on routes
  overridable for testing purposes
- Rewrites lots of usages in tests. For some reason `volatile` was
  frequently used in tests when it was not needed.
- Adds `additionalDependentKeys` array to `map`, `filter` and `sort`
  array functions. `sort` was overlooked in RFC, but suffers from the
  same problem so it shouldn't need an additional RFC.
- Adds tests for `additionalDependentKeys`
@pzuraq pzuraq force-pushed the deprecation/computed-modifiers branch from 229c0bf to f3693d6 Compare January 11, 2019 19:01
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome job, thank you!

@rwjblue
Copy link
Member

rwjblue commented Jan 12, 2019

CI failure is due to linting:


/home/travis/build/emberjs/ember.js/packages/@ember/-internals/metal/lib/computed.ts
  479:23  error  Replace `obj` with `⏎········obj⏎······`  prettier/prettier
✖ 1 problem (1 error, 0 warnings)
  1 error and 0 warnings potentially fixable with the `--fix` option.

@pzuraq pzuraq force-pushed the deprecation/computed-modifiers branch from 1e7d959 to 95973cf Compare January 12, 2019 18:12
Copy link
Member

@rwjblue rwjblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deprecation guide PR landed in ember-learn/deprecation-app#254, and I confirmed URL's for deprecations...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants