Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUGFIX] fix issue around how undefined stored in _values chain #17406

Merged
merged 1 commit into from
Jun 20, 2019
Merged

[BUGFIX] fix issue around how undefined stored in _values chain #17406

merged 1 commit into from
Jun 20, 2019

Conversation

bekzod
Copy link
Contributor

@bekzod bekzod commented Dec 22, 2018

using UNDEFINED const when storing undefined values in _values

fixes #17022

@bekzod bekzod changed the title fix issue around how undefined stored in _values chain [BUGFIX] fix issue around how undefined stored in _values chain Dec 22, 2018
@bekzod bekzod force-pushed the fix-undefined-issue branch 2 times, most recently from 3bcaa5d to 2870032 Compare December 22, 2018 04:14
@bekzod bekzod force-pushed the fix-undefined-issue branch 2 times, most recently from 9319644 to 5d51436 Compare December 24, 2018 04:30
@bekzod
Copy link
Contributor Author

bekzod commented Dec 24, 2018

I think it affects LTS releases too, so can update label to [BUGFIX LTS]

@bekzod
Copy link
Contributor Author

bekzod commented Jun 20, 2019 •
edited
Loading

rebased, maybe worth merging has reproduction and fix 😉

@rwjblue rwjblue merged commit d212c19 into emberjs:master Jun 20, 2019
@rwjblue
Copy link
Member

rwjblue commented Jun 20, 2019

Thanks @bekzod !

@bekzod bekzod deleted the fix-undefined-issue branch June 20, 2019 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rwjblue rwjblue rwjblue approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

DEFAULT_GETTER_FUNCTION returns wrong value if actual value is set to undefined
2 participants
@bekzod @rwjblue