Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX release] Ensure legacy build of template compiler can be loaded. #17403

Merged
merged 1 commit into from
Dec 21, 2018

Commits on Dec 21, 2018

  1. [BUGFIX release] Ensure legacy build of template compiler can be loaded.

    Without this change the following error was triggered:
    
    ```
    node -e 'require("ember-source/dist/legacy/ember-template-compiler")'
    /Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:21
          throw new Error('Could not find module ' + name + ' required by: ' + referrerName);
          ^
    
    Error: Could not find module ember-babel required by: @glimmer/compiler
        at missingModule (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:21:13)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:45:7)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
        at internalRequire (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:58:22)
        at requireModule (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:99:14)
        at /Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:14842:92
        at Object.<anonymous>
        (/Users/rjackson/src/emberjs/ember.js/dist/legacy/ember-template-compiler.js:14845:2)
    ```
    
    This happened because the `ember-template-compiler.js` bundle did not
    include the babel helpers needed.
    rwjblue committed Dec 21, 2018
    Configuration menu
    Copy the full SHA
    03be800 View commit details
    Browse the repository at this point in the history